Skip to content

allow isolated build to succeed #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asottile-augment wants to merge 1 commit into
base: augment
Choose a base branch
from
+3 −0
Open

allow isolated build to succeed #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["setuptools>=77.0.3", "torch"]
Copy link

@augment-app-staging augment-app-staging bot Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools>=77.0.3 effectively requires Python >=3.9 (per setuptools’ own requires_python), so isolated builds will fail on Python 3.7/3.8 even though this repo still references 3.6–3.8 (e.g., setup.py classifiers, docs build on 3.7). Can you confirm dropping <3.9 is intended?

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link

@augment-app-staging augment-app-staging bot Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding torch to build-system.requires means PEP 517 build isolation will install a potentially different PyTorch than the runtime environment, which can break precompiled op loads via assert_torch_info (torch/cuda mismatch). It can also cause installs to fail on setups where torch isn’t pip-installable in the isolated env (even if torch is available via conda/system site-packages).

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

build-backend = "setuptools.build_meta:__legacy__"