Conversation
🤖 Augment PR SummarySummary: Adds a minimal Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| @@ -0,0 +1,3 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=77.0.3", "torch"] | |||
There was a problem hiding this comment.
setuptools>=77.0.3 effectively requires Python >=3.9 (per setuptools’ own requires_python), so isolated builds will fail on Python 3.7/3.8 even though this repo still references 3.6–3.8 (e.g., setup.py classifiers, docs build on 3.7). Can you confirm dropping <3.9 is intended?
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| @@ -0,0 +1,3 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=77.0.3", "torch"] | |||
There was a problem hiding this comment.
Adding torch to build-system.requires means PEP 517 build isolation will install a potentially different PyTorch than the runtime environment, which can break precompiled op loads via assert_torch_info (torch/cuda mismatch). It can also cause installs to fail on setups where torch isn’t pip-installable in the isolated env (even if torch is available via conda/system site-packages).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
No description provided.