Skip to content

allow isolated build to succeed#4

Open
asottile-augment wants to merge 1 commit intoaugmentfrom
asottile-isolated-build
Open

allow isolated build to succeed#4
asottile-augment wants to merge 1 commit intoaugmentfrom
asottile-isolated-build

Conversation

@asottile-augment
Copy link

No description provided.

@asottile-augment asottile-augment marked this pull request as ready for review March 4, 2026 20:56
@augment-app-staging
Copy link

🤖 Augment PR Summary

Summary: Adds a minimal pyproject.toml so PEP 517 isolated builds can provision build-time dependencies.

Changes:

  • Declares setuptools and torch as build requirements
  • Uses the legacy setuptools backend to keep the existing setup.py-driven build flow

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augment-app-staging augment-app-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@@ -0,0 +1,3 @@
[build-system]
requires = ["setuptools>=77.0.3", "torch"]
Copy link

@augment-app-staging augment-app-staging bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools>=77.0.3 effectively requires Python >=3.9 (per setuptools’ own requires_python), so isolated builds will fail on Python 3.7/3.8 even though this repo still references 3.6–3.8 (e.g., setup.py classifiers, docs build on 3.7). Can you confirm dropping <3.9 is intended?

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@@ -0,0 +1,3 @@
[build-system]
requires = ["setuptools>=77.0.3", "torch"]
Copy link

@augment-app-staging augment-app-staging bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding torch to build-system.requires means PEP 517 build isolation will install a potentially different PyTorch than the runtime environment, which can break precompiled op loads via assert_torch_info (torch/cuda mismatch). It can also cause installs to fail on setups where torch isn’t pip-installable in the isolated env (even if torch is available via conda/system site-packages).

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants