OptimizeInstructions: Consecutive instrs are not equal if one tees and one reads#8415
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Mar 4, 2026
Merged
OptimizeInstructions: Consecutive instrs are not equal if one tees and one reads#8415kripken merged 2 commits intoWebAssembly:mainfrom
kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
areConsecutiveInputsEquallooks at fallthrough values when comparing, butit must look at the original values for effects. It did that for the right side, but
not the left.
This was incorrect for a very long time, and only uncovered by
#8355 (comment)
I suspect it might have even been undiscoverable until then, even though it
was logically false (in that nothing reached it that could hit the bug).