OptimizeInstructions: Improve areConsecutiveInputsEqualAndFoldable#8355
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Feb 23, 2026
Merged
OptimizeInstructions: Improve areConsecutiveInputsEqualAndFoldable#8355kripken merged 2 commits intoWebAssembly:mainfrom
kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
Merged
Member
|
Fuzzer is not happy! Bisected the following to this change: |
Member
Author
|
Yikes, while this PR's changes were right, it uncovered a bug in the code it calls... Fix in #8415 |
kripken
added a commit
that referenced
this pull request
Mar 4, 2026
…d one reads (#8415) `areConsecutiveInputsEqual` looks at fallthrough values when comparing, but it must look at the original values for effects. It did that for the right side, but not the left. This was incorrect for a very long time, and only uncovered by #8355 (comment) I suspect it might have even been undiscoverable until then, even though it was logically false (in that nothing reached it that could hit the bug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To check if we can fold
A, BintoA, we can just check ifBhaseffects we can't remove. The old code used a utility that checks if
Ais also removable, but that is suboptimal, and that entireutility is not needed.