Fix stale worker-count prose after http.pool config refactor#386
Merged
roxblnfk merged 3 commits intoroxblnfk-patch-1from Mar 5, 2026
Merged
Fix stale worker-count prose after http.pool config refactor#386roxblnfk merged 3 commits intoroxblnfk-patch-1from
roxblnfk merged 3 commits intoroxblnfk-patch-1from
Conversation
…reference) Co-authored-by: roxblnfk <4152481+roxblnfk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on Yii configuration for RoadRunner setup
Fix stale worker-count prose after http.pool config refactor
Mar 5, 2026
roxblnfk
reviewed
Mar 5, 2026
| files are static ones except `.php` and `.htaccess`. Also, we're sending an additional header. | ||
| We're specifying that the entry script is `worker.php`, the server listens on port 8080, `public` directory | ||
| files are served statically except `.php` and `.htaccess`, and workers are limited to 192 MB of memory before | ||
| being recycled. Also, we're sending an additional header. |
Member
There was a problem hiding this comment.
@copilot Read the RoadRunner documentation and fix this statement. Workers do not terminate when the limit is exceeded. It's a soft limit. If a worker exceeds it, the worker will restart after processing the request.
Member
There was a problem hiding this comment.
@copilot Read the RoadRunner documentation and fix this statement. Workers do not terminate when the limit is exceeded. It's a soft limit. If a worker exceeds it, the worker will restart after processing the request.
Contributor
Author
There was a problem hiding this comment.
Fixed in 4d06eaf — the sentence now describes max_worker_memory as a soft limit and explains that the worker restarts after finishing its current request when the limit is exceeded.
Co-authored-by: roxblnfk <4152481+roxblnfk@users.noreply.github.com>
roxblnfk
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_worker_memorybehaviour: it is a soft limit — the worker restarts after finishing the current request, not immediately🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.