Restore 'Install a package with a dependency' test#224
Merged
swissspidy merged 7 commits intomainfrom Mar 3, 2026
Merged
Conversation
- Remove @broken tag from the test scenario - Update @require-php-5.6 to @require-php-7.2 (matches halaxa/json-machine requirement) - Replace yoast/wp-cli-faker (unavailable) with 10up/wpcli-vulnerability-scanner - Update assertions to use new package and dependency names (halaxa/json-machine) Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Restore 'Install a package with a dependency' test
Restore 'Install a package with a dependency' test
Mar 2, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Replace 10up/wpcli-vulnerability-scanner (deprecated) with wp-cli-test/updateable-package as suggested in code review. The package requires wp-cli/wp-cli as its dependency, which appears in vendor but not in wp package list. Remove @require-php-7.2 tag since updateable-package has no PHP version restriction. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the previously @broken “Install a package with a dependency” Behat test by updating it to use a different package and refreshing the assertions around installed vendor directories and package listing behavior.
Changes:
- Removed the
@brokenmarker and updated PHP requirement tagging for the scenario. - Switched the package being installed and updated vendor-directory assertions for the package and its dependency.
- Updated
is-installed,list, anduninstallassertions to match the new expected package behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
swissspidy
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Install a package with a dependencytest was marked@brokendue to rate limiting. Additionally,yoast/wp-cli-faker(the original test package) has since been removed from Packagist and the WP-CLI package index.Changes
yoast/wp-cli-faker→wp-cli-test/updateable-packagewp-cli/wp-clias a dependency, which is installed into the packages vendor dir but does not appear inwp package list@broken(restoring the test) and@require-php-5.6(no PHP version restriction needed)is-installed,list, anduninstallsteps updated to reflect the new package and itswp-cli/wp-clidependencyOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.