Add more CI workflows for wolfSSH #884
Open
aidangarske wants to merge 1 commit intowolfSSL:masterfrom
Open
Conversation
Member
aidangarske
commented
Mar 3, 2026
- codespell.yml: Automated spell checking with project-specific ignore list
- multi-compiler.yml: Test builds with gcc-11/12/13 and clang-14/15/17
- sanitizer.yml: Memory safety testing with ASan, UBSan, and LeakSan
There was a problem hiding this comment.
Pull request overview
Adds additional GitHub Actions CI coverage (codespell, multi-compiler builds, sanitizers) and aligns the codebase with automated spell-checking by fixing various typos across source, tests, examples, and docs.
Changes:
- Add new CI workflows: codespell, multi-compiler build matrix, and sanitizer runs.
- Fix widespread spelling/wording issues in comments, logs, help text, and documentation.
- Adjust portability/warning-handling in
wolfssh/port.hfor Clang variadic-macro diagnostics.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
wolfssh/port.h |
Adds Clang diagnostic push/pop around variadic macro definitions. |
wolfssh/internal.h |
Fixes typo in struct field comment. |
tests/auth.c |
Fixes test output string typo. |
tests/api.c |
Fixes comment typo. |
src/wolfterm.c |
Fixes comment typos in control-sequence handling. |
src/wolfsftp.c |
Fixes multiple typos in comments/log strings. |
src/wolfscp.c |
Fixes typos in comments/log strings. |
src/ssh.c |
Fixes typos in comments/log strings. |
src/internal.c |
Fixes typos in comments. |
src/certman.c |
Fixes typos in comments/log strings. |
examples/sftpclient/sftpclient.c |
Fixes typos in comments/print output. |
examples/echoserver/echoserver.c |
Fixes typos in comments/print output (including usage text). |
examples/client/client.c |
Fixes typos and tightens strncpy bound for sun_path. |
apps/wolfsshd/wolfsshd.c |
Fixes typos in comments/log strings. |
apps/wolfsshd/test/ssh_kex_algos.sh |
Fixes typo in script comment. |
apps/wolfsshd/test/run_all_sshd_tests.sh |
Fixes typo in script comment. |
apps/wolfsshd/test/README.md |
Fixes typo in README text. |
apps/wolfsshd/configuration.h |
Fixes typo in comment. |
apps/wolfsshd/configuration.c |
Fixes typo in TODO comment. |
apps/wolfsshd/auth.c |
Fixes typos in comments/log strings. |
apps/wolfssh/wolfssh.c |
Fixes typos in comments. |
ChangeLog.md |
Fixes typos in release notes. |
.github/workflows/sanitizer.yml |
New sanitizer CI workflow (ASan/UBSan/LeakSan). |
.github/workflows/multi-compiler.yml |
New multi-compiler CI workflow (gcc/clang matrix). |
.github/workflows/codespell.yml |
New codespell CI workflow with project ignore list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
examples/client/client.c:579
sun_pathis now truncated tosizeof(sun_path) - 1, butsizeis still computed fromstrlen(sockName). IfsockNameexceedssun_path,connect()will be called with an addrlen that doesn't match the actual (truncated) path and can exceedsizeof(struct sockaddr_un). Compute the length with a boundedstrnlen()/WSTRNLEN()and/or validate thatsockNamefits before callingconnect().
strncpy(name->sun_path, sockName, sizeof(name->sun_path) - 1);
name->sun_path[sizeof(name->sun_path) - 1] = '\0';
size = strlen(sockName) +
offsetof(struct sockaddr_un, sun_path);
apps/wolfssh/wolfssh.c:606
- Same issue as in the client example:
sun_pathis truncated tosizeof(sun_path) - 1, butsizeusesWSTRLEN(sockName)(unbounded). If the env var path is longer thansun_path,connect()may be passed an incorrect/oversized addrlen. Use a bounded length (e.g.,WSTRNLEN) and/or reject oversized paths before callingconnect().
WSTRNCPY(name->sun_path, sockName, sizeof(name->sun_path) - 1);
name->sun_path[sizeof(name->sun_path) - 1] = '\0';
size = WSTRLEN(sockName) +
offsetof(struct sockaddr_un, sun_path);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
29bd248 to
09144d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.