Draft
Conversation
Merging this PR will improve performance by 26.25%
Performance Changes
Comparing 
Footnotes
|
AdamGS
force-pushed
the
adamg/needless-pass-by-value
branch
from
1ed9266 to
fbcdb97
Compare
danking
reviewed
Mar 4, 2026
Comment on lines
-27
to
-30
| pub fn new(scale_factor: String, use_remote_data_dir: Option<String>) -> Result<Self> { | ||
| pub fn new(scale_factor: &str, use_remote_data_dir: Option<String>) -> Result<Self> { | ||
| Ok(Self { | ||
| scale_factor: scale_factor.clone(), | ||
| data_url: Self::create_data_url(&use_remote_data_dir, &scale_factor)?, |
Contributor
There was a problem hiding this comment.
this feels like just an ordering issue right?
Suggested change
| pub fn new(scale_factor: String, use_remote_data_dir: Option<String>) -> Result<Self> { | |
| pub fn new(scale_factor: &str, use_remote_data_dir: Option<String>) -> Result<Self> { | |
| Ok(Self { | |
| scale_factor: scale_factor.clone(), | |
| data_url: Self::create_data_url(&use_remote_data_dir, &scale_factor)?, | |
| pub fn new(scale_factor: String, use_remote_data_dir: Option<String>) -> Result<Self> { | |
| let data_url = Self::create_data_url(&use_remote_data_dir, scale_factor)?; | |
| Ok(Self { | |
| scale_factor: scale_factor, | |
| data_url, |
Contributor
Author
There was a problem hiding this comment.
I've played around with that and it didn't work? not sure
AdamGS
force-pushed
the
adamg/needless-pass-by-value
branch
from
1aef092 to
59f6e7f
Compare
AdamGS
commented
Mar 4, 2026
| pub mod parquet; | ||
| pub mod vortex; | ||
|
|
||
| pub fn chunked_to_vec_record_batch( |
AdamGS
commented
Mar 4, 2026
| @@ -291,56 +291,56 @@ package = "getrandom" | |||
| version = "0.3.1" | |||
|
|
|||
| [workspace.lints.rust] | |||
Contributor
Author
There was a problem hiding this comment.
warn lets us enforce in CI and have a nicer time locally
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
AdamGS
force-pushed
the
adamg/needless-pass-by-value
branch
from
9b5b93f to
3ab051c
Compare
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint seems very useful, there's just a lot of stuff to work through so I'm stashing it for a bit