chore: Convert SliceKernel impls to SliceReduce#6727
Open
Conversation
Merging this PR will improve performance by 42.12%
Performance Changes
Comparing 
Footnotes
|
github-actions
bot
removed
the
action/benchmark-sql
Contributor
|
Where they are constant time we should indeed be reduce rules. RunEnd cannot be a reduce rule since it needs access to the data. In either case, it should have no impact on execution time or available optimizations if the other compute kernels were written to not recurse incorrectly. @joseph-isaacs and I are planning an API change to make it harder to do the wrong thing here |
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Author
Thanks for clarifying! |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Resolving `SliceArray` nodes at optimization time rather than execution time lets subsequent passes apply further compute pushdown. Changed for: `ALPVTable`, `ALPRDVTable`, `BitPackedVTable`, `RLEVTable`, `SparseVTable`, `ChunkedVTable` Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Author
Dropped this change for runend. |
0ax1
changed the title
SliceKernel impls to SliceReduceSliceKernel impls to SliceReduce
0ax1
added
changelog/chore
0ax1
changed the title
SliceKernel impls to SliceReduceSliceKernel impls to SliceReduce
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
joseph-isaacs
requested changes
Mar 2, 2026
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
This was intentionally marked as a kernel, see need to change the way we handle patches to move over
Comment on lines
19
to
23
| array | ||
| .patches() | ||
| .map(|p| p.slice(range)) | ||
| .transpose()? | ||
| .flatten(), |
Contributor
There was a problem hiding this comment.
This is a uses buffers
Contributor
There was a problem hiding this comment.
Yea, if we added a PatchesArray I think this could work by wrapping with SliceArray
Contributor
There was a problem hiding this comment.
with galp style patches all patches slicing is metadata only
Contributor
|
To do this we have to handle patches correctly, maybe using a custom array. |
Contributor
|
Do we still want this pr? |
Contributor
|
i have a separate pr #6815 in progress which adds the new array for patches and implements the slicerule |
Contributor
|
I'm still not sure we want a patches array. At least, not yet. Unless we have some way of passing down an "is_defined" mask into execution, there's no way for the child array to know whether some checked operation should fail or not. e.g. the child of a Patches array may overflow on some arithmetic, but the patch would have succeeded. We need a way to tell the child to ignore the overflow for the invalid positions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving
SliceArraynodes at optimization time rather than execution time.Changed for:
ALPVTable,ALPRDVTable,BitPackedVTable,RLEVTable,SparseVTable,ChunkedVTable.