Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will degrade performance by 18.01%
Performance Changes
Comparing 
Footnotes
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
force-pushed
the
ngates/aggregate-fns-mean
branch
from
1f43f0b to
ade8613
Compare
Deploying vortex-bench with
|
| Latest commit: |
ade8613
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6439fe4d.vortex-93b.pages.dev |
| Branch Preview URL: | https://ngates-aggregate-fns-mean.vortex-93b.pages.dev |
| if !input_dtype.is_int() && !input_dtype.is_float() { | ||
| vortex_bail!("Mean requires numeric input, got {}", input_dtype); | ||
| } | ||
| Ok(DType::Primitive(PType::F64, Nullability::Nullable)) |
There was a problem hiding this comment.
Why is this nullable?
| self.sum += sum_scalar | ||
| .as_primitive() | ||
| .typed_value::<f64>() | ||
| .unwrap_or(0.0); | ||
| self.count += count_scalar | ||
| .as_primitive() | ||
| .typed_value::<u64>() | ||
| .unwrap_or(0); |
There was a problem hiding this comment.
use mean = mean + (x - mean) / n
There was a problem hiding this comment.
This isn't merge-able
2 participants
Mean AggregateFn