Skip to content

fix(angular): resolve e2e tests comparison mismatches#58

Merged
Brooooooklyn merged 1 commit intomainfrom
fix/clickup-comparison-alignment
Mar 4, 2026
Merged

fix(angular): resolve e2e tests comparison mismatches#58
Brooooooklyn merged 1 commit intomainfrom
fix/clickup-comparison-alignment

Conversation

@Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Mar 4, 2026

Fix multiple compiler output divergences from Angular TS:

  • fix(variable_optimization): handle Oxc's split handler_expression architecture
    in optimizeSaveRestoreView, removing unnecessary restoreView/resetView wrapping
  • fix(variable_optimization): reorder optimization steps to match Angular TS
    (arrow functions and listener handlers before create/update ops)
  • fix(variable_optimization): include Animation handlers in save/restore optimization
  • fix(emitter): emit non-ASCII characters as raw UTF-8 instead of \uNNNN escapes
  • fix(ordering): add OpKind::Control to update op ordering phase (priority 8, last)
  • fix(reify): add missing name string literal as second argument to ɵɵcontrol()
  • fix(emit): emit host binding pool constants (pure functions) alongside template
    declarations, matching Angular TS's shared ConstantPool behavior
  • fix(entities): use greedy &-to-; matching in decode_entities_in_string to
    replicate Angular TS's /&([^;]+);/g regex behavior

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Note

Cursor Bugbot is generating a summary for commit b424135. Configure here.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn force-pushed the fix/clickup-comparison-alignment branch from b424135 to 4bbfb33 Compare March 4, 2026 08:07
@Brooooooklyn Brooooooklyn changed the title fix(angular): resolve ClickUp comparison mismatches (681 → 78 import-only) fix(angular): resolve e2e tests comparison mismatches Mar 4, 2026
@Brooooooklyn Brooooooklyn force-pushed the fix/clickup-comparison-alignment branch from 4bbfb33 to 72fb262 Compare March 4, 2026 08:30
@Brooooooklyn Brooooooklyn force-pushed the fix/clickup-comparison-alignment branch from 72fb262 to d1b9a27 Compare March 4, 2026 08:44
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@Brooooooklyn Brooooooklyn force-pushed the fix/clickup-comparison-alignment branch from d1b9a27 to 061cd8c Compare March 4, 2026 09:02
Fix multiple compiler output divergences from Angular TS:

- fix(variable_optimization): handle Oxc's split handler_expression architecture
  in optimizeSaveRestoreView, removing unnecessary restoreView/resetView wrapping
- fix(variable_optimization): reorder optimization steps to match Angular TS
  (arrow functions and listener handlers before create/update ops)
- fix(variable_optimization): include Animation handlers in save/restore optimization
- fix(emitter): emit non-ASCII characters as raw UTF-8 instead of \uNNNN escapes
- fix(ordering): add OpKind::Control to update op ordering phase (priority 8, last)
- fix(reify): add missing name string literal as second argument to ɵɵcontrol()
- fix(emit): emit host binding pool constants (pure functions) alongside template
  declarations, matching Angular TS's shared ConstantPool behavior
- fix(entities): use greedy &-to-; matching in decode_entities_in_string to
  replicate Angular TS's /&([^;]+);/g regex behavior

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Brooooooklyn Brooooooklyn force-pushed the fix/clickup-comparison-alignment branch from 061cd8c to d00873c Compare March 4, 2026 09:03
@Brooooooklyn Brooooooklyn merged commit b024dce into main Mar 4, 2026
4 checks passed
@Brooooooklyn Brooooooklyn deleted the fix/clickup-comparison-alignment branch March 4, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant