fix(core): settings scroll in dock panel and standalone app#181
Merged
webfansplz merged 1 commit intomainfrom Feb 26, 2026
Merged
fix(core): settings scroll in dock panel and standalone app#181webfansplz merged 1 commit intomainfrom
webfansplz merged 1 commit intomainfrom
Conversation
commit: |
There was a problem hiding this comment.
Pull request overview
This pull request fixes a scrolling issue in the settings view that affected both the dock panel and standalone app modes. The problem was caused by using h-screen (100vh) on the root element, which doesn't work correctly when the component is embedded within a parent container that has its own height constraints.
Changes:
- Refactored the ViewBuiltinSettings.vue template to use a nested container structure for proper scroll handling
- Updated the auto-generated CSS file (formatting only, no functional changes)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ViewBuiltinSettings.vue | Changed from single-div with h-screen to nested structure with h-full overflow-hidden outer container and h-full overflow-auto inner scrollable container to fix scrolling in both dock panel and standalone contexts |
| .generated/css.ts | Auto-generated CSS file with formatting changes only (export statement format) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.