Skip to content

fix(core): settings scroll in dock panel and standalone app#181

Merged
webfansplz merged 1 commit intomainfrom
fix/settings-ui
Feb 26, 2026
Merged

fix(core): settings scroll in dock panel and standalone app#181
webfansplz merged 1 commit intomainfrom
fix/settings-ui

Conversation

@webfansplz
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 26, 2026 04:32
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 26, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/devtools@181
npm i https://pkg.pr.new/@vitejs/devtools-kit@181
npm i https://pkg.pr.new/@vitejs/devtools-rolldown@181
npm i https://pkg.pr.new/@vitejs/devtools-rpc@181

commit: 4d8f5ae

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a scrolling issue in the settings view that affected both the dock panel and standalone app modes. The problem was caused by using h-screen (100vh) on the root element, which doesn't work correctly when the component is embedded within a parent container that has its own height constraints.

Changes:

  • Refactored the ViewBuiltinSettings.vue template to use a nested container structure for proper scroll handling
  • Updated the auto-generated CSS file (formatting only, no functional changes)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ViewBuiltinSettings.vue Changed from single-div with h-screen to nested structure with h-full overflow-hidden outer container and h-full overflow-auto inner scrollable container to fix scrolling in both dock panel and standalone contexts
.generated/css.ts Auto-generated CSS file with formatting changes only (export statement format)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@webfansplz webfansplz merged commit 0816fe9 into main Feb 26, 2026
13 checks passed
@webfansplz webfansplz deleted the fix/settings-ui branch February 26, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants