fix(vm): handle AsyncGeneratorAwaitReturn PromiseResolve abrupt completion (#709)#958
Merged
aapoalas merged 5 commits intotrynova:mainfrom Mar 7, 2026
Conversation
aapoalas
requested changes
Feb 22, 2026
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Alright, nice! This is a meaningful change that fixes some issues, very very nice indeed!
Some issues remain though, let's fix those before merging this <3
...s/control_abstraction_objects/async_generator_objects/async_generator_abstract_operations.rs
Outdated
Show resolved
Hide resolved
...s/control_abstraction_objects/async_generator_objects/async_generator_abstract_operations.rs
Outdated
Show resolved
Hide resolved
...s/control_abstraction_objects/async_generator_objects/async_generator_abstract_operations.rs
Outdated
Show resolved
Hide resolved
...s/control_abstraction_objects/async_generator_objects/async_generator_abstract_operations.rs
Outdated
Show resolved
Hide resolved
...s/control_abstraction_objects/async_generator_objects/async_generator_abstract_operations.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
i'm dead but will come back around in the next few days :) |
replygirl
changed the title
Member
|
Too much simplification. |
Contributor
Author
LMAO i'm too tired |
replygirl
force-pushed
the
fix/vm-709-await-return-promise-abrupt
branch
from
68a5f07 to
13f2caa
Compare
replygirl
changed the title
…GeneratorCompleteStep on broken promises
aapoalas
force-pushed
the
fix/vm-709-await-return-promise-abrupt
branch
from
c705272 to
e5aff15
Compare
Member
|
Sorry @replygirl, I went and did the changes needed :) This turned out to require a bit more effort, as adding error throwing to |
aapoalas
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #950
Fixes #709
Refs #950