Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://docs.docker.com/engine/network/links/,
linksare not recommended to use anymore. Also, it is currently not possible to use(Docker)ComposeContainer#withExposedServiceonpodmanas it uses links via an APIaddLinkand it looks as ifpodmandoesn't offer links at all (whiledockerdoes). TheaddLinkAPI has been deprecated almost 10 years ago and this PR addresses this deprecation and replaces it with anetworkbased approach.Sadly, I cannot run all tests in one go on my machine. Tests that fail in the "big run" work nicely when I run them individually. So it would be really great if somebody could do a review (I must have missed something in there!) and I would be happy to see the tests on the CI here, so i can see the results and continue on this PR.