fix duplicate properties from inherited interfaces#590
Merged
ktoso merged 2 commits intoswiftlang:mainfrom Mar 6, 2026
Merged
Conversation
previously we fixes duplicated properties from classes, but missed them from interfaces. This fixes that & adds a tests
Collaborator
|
Neat, thanks for catching this |
ktoso
approved these changes
Mar 6, 2026
Contributor
Author
|
Thanks for looking into it! 🙏 Does it format for me, or do we need to drop the comma? 😅 |
Collaborator
|
Yeah the current formatting rules dislike this comma... I'll actually undo this, the trailing comma is nice. wait pls |
ktoso
reviewed
Mar 6, 2026
Tests/SwiftJavaToolLibTests/WrapJavaTests/BasicWrapJavaTests.swift
Outdated
Show resolved
Hide resolved
Collaborator
|
It's seems it's literarily not configurable swiftlang/swift-format#332 Can you please fix the formatting so that swift-format is happy? |
…wift Co-authored-by: Konrad `ktoso` Malawski <konrad.malawski@project13.pl>
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously we fixed duplicated properties from classes, but missed them from interfaces.
This fixes that & adds a test for it.