[6.x] Avoid opening Command Palette when Bard field is focused & text is selected#14019
Merged
jasonvarga merged 7 commits into6.xfrom Mar 6, 2026
Merged
[6.x] Avoid opening Command Palette when Bard field is focused & text is selected#14019jasonvarga merged 7 commits into6.xfrom
jasonvarga merged 7 commits into6.xfrom
Conversation
jasonvarga
requested changes
Feb 20, 2026
Member
jasonvarga
left a comment
There was a problem hiding this comment.
I don't love having Bard code inside command palette. I wonder if there's an alternative.
Member
Author
|
I've refactored it to use a callback approach instead... Statamic.$commandPalette.preventIf(() => {
const selection = window.getSelection();
const node = selection?.anchorNode;
const isInBard = node?.parentElement?.closest('.bard-editor') !== null;
return isInBard && selection?.toString().length > 0;
});Let me know what you think. |
Member
|
This works nicely. Thanks. However since it prevents cmd+k when you have text selected in bard, cmd+k will do absolutely nothing on a mac. No link popover, no command palette. So I've switched the bard link shortcut back to cmd+k. The only reason we changed it from cmd was because of the command palette conflict. Now that its back to cmd, it matches cmd+b for bold, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where
cmd+kto open the Bard link stack conflicts withmod+kto open the Command Palette.This PR fixes it by opening the link stack when text is selected and opening the Command Palette when it's not.
Fixes #14009