Skip to content

feat(iaas): use SNA ipv4 nameserver when nameserver is unset in network resource#1281

Merged
Manuelvaas merged 3 commits intomainfrom
feat/STACKITTPR-345-send-null-for-network-ipv4-nameservers-when-unset
Mar 6, 2026
Merged

feat(iaas): use SNA ipv4 nameserver when nameserver is unset in network resource#1281
Manuelvaas merged 3 commits intomainfrom
feat/STACKITTPR-345-send-null-for-network-ipv4-nameservers-when-unset

Conversation

@marceljk
Copy link
Contributor

@marceljk marceljk commented Mar 6, 2026

Description

relates to STACKITTPR-345

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner March 6, 2026 13:20
@marceljk marceljk force-pushed the feat/STACKITTPR-345-send-null-for-network-ipv4-nameservers-when-unset branch from 79a4a75 to 875c6db Compare March 6, 2026 16:45
@marceljk marceljk force-pushed the feat/STACKITTPR-345-send-null-for-network-ipv4-nameservers-when-unset branch from 875c6db to 449da14 Compare March 6, 2026 16:46
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/network 46.58% (-2.08%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/network/datasource.go 58.68% (-2.86%) 121 (-9) 71 (-9) 50 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/network/resource.go 42.36% (-1.61%) 347 (-10) 147 (-10) 200 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/network/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/network/resource_test.go

@Manuelvaas Manuelvaas enabled auto-merge (squash) March 6, 2026 16:50
@Manuelvaas Manuelvaas merged commit 8555662 into main Mar 6, 2026
3 checks passed
@Manuelvaas Manuelvaas deleted the feat/STACKITTPR-345-send-null-for-network-ipv4-nameservers-when-unset branch March 6, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants