Add r2h-ifname parameter support for RTSP, HTTP proxy, and multicast; rename ifname to r2h-ifname by Claude · Pull Request #378 · stackia/rtp2httpd

Claude · 2026-03-05T09:03:58Z

Analyze the M3U conversion logic for r2h-ifname parameter handling
Verify extract_dynamic_params preserves r2h-ifname and r2h-ifname-fcc
Test if parameters in M3U URLs work correctly after conversion
Verify parameter override capability (URL params override M3U params)
Review all bind_to_upstream_interface calls for completeness

Original prompt

This section details on the original issue you should resolve

<issue_title>多组播网络接口的建议直接在http链接上增加一个参数?ifname=ethx用于选择组播走哪个口出去</issue_title>
<issue_description>部分有DTMB接收的信号下来补充运营商没有的频道，两个口开了两个docker跑，直接通过http携带网络接口参数就不用这么麻烦了。</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

Fixes 多组播网络接口的建议直接在http链接上增加一个参数?ifname=ethx用于选择组播走哪个口出去 #376

github-actions · 2026-03-05T09:06:35Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-378.eastasia.1.azurestaticapps.net

Co-authored-by: stackia <5107241+stackia@users.noreply.github.com>

github-actions · 2026-03-05T09:14:38Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-378.eastasia.1.azurestaticapps.net

… add r2h-ifname-fcc for FCC Co-authored-by: stackia <5107241+stackia@users.noreply.github.com>

…rd declaration Co-authored-by: stackia <5107241+stackia@users.noreply.github.com>

github-actions · 2026-03-05T09:35:06Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-378.eastasia.1.azurestaticapps.net

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d7ce3507f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-05T09:39:18Z

src/service.c

+    http_parse_query_param(query_start + 1, "r2h-ifname", ifname_value,
+                           sizeof(ifname_value));


Strip r2h-ifname from proxied HTTP query strings

This path parses r2h-ifname into result->ifname but never removes it from result->http_url; the subsequent service_extract_seek_params(...) call only strips seek-related parameters. When clients use ?r2h-ifname=..., the proxy forwards that internal control parameter upstream, which can break backends that require an exact query string (for example signed URLs or strict parameter validation).

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-05T09:39:19Z

src/service.c

+    http_parse_query_param(query_start + 1, "r2h-ifname", ifname_value,
+                           sizeof(ifname_value));


Remove r2h-ifname before constructing RTSP upstream URL

The RTSP parser now reads r2h-ifname but leaves it in url_part before building result->rtsp_url, so this internal routing flag is sent to the upstream RTSP server as part of the request URI. This can cause stream setup failures on servers that do not ignore unknown query parameters, specifically whenever per-URL interface selection is used.

Useful? React with 👍 / 👎.

Copilot

Pull request overview

Adds per-URL upstream interface selection via new query parameters (r2h-ifname, r2h-ifname-fcc) so different streams can be bound to different NICs without changing global config.

Changes:

Extend service_t to carry per-service interface overrides and clone/free them correctly.
Parse r2h-ifname / r2h-ifname-fcc from RTP/RTSP/HTTP URLs and prefer them over global upstream-interface settings when binding sockets.
Update Chinese and English URL format documentation with the new parameters and examples.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/stream.c	Passes `service` into HTTP proxy connect and attaches `service` to RTSP session for per-service config access.
src/service.h	Adds per-service interface override fields (`ifname`, `ifname_fcc`).
src/service.c	Parses interface query params; stores/clones/frees them on services.
src/rtsp.h	Adds `service_t*` to RTSP session for per-service interface selection.
src/rtsp.c	Uses per-service interface (if set) when binding RTSP TCP/UDP sockets.
src/multicast.c	Uses per-service interface (if set) when joining/binding multicast sockets.
src/http_proxy.h	Updates `http_proxy_connect` signature to accept optional `service`.
src/http_proxy.c	Uses per-service interface (if set) when binding HTTP proxy upstream socket.
src/fcc.c	Uses per-service FCC interface (if set) when binding FCC socket.
docs/guide/url-formats.md	Documents `r2h-ifname` and `r2h-ifname-fcc` in CN guide.
docs/en/guide/url-formats.md	Documents `r2h-ifname` and `r2h-ifname-fcc` in EN guide.

Comments suppressed due to low confidence (1)

src/service.c:918

service_create_from_rtsp_url() extracts r2h-ifname for local binding but does not remove it from url_part before building result->rtsp_url. That means the RTSP server will receive r2h-ifname as part of the RTSP request URI, which can cause upstream incompatibilities. Strip r2h-ifname from the query string (similar to the seek param removal) after parsing it.

  /* Extract seek parameters from query string (modifies url_part in-place) */
  query_start = strchr(url_part, '?');
  if (query_start) {
    /* Extract r2h-ifname parameter before processing seek params */
    http_parse_query_param(query_start + 1, "r2h-ifname", ifname_value,
                           sizeof(ifname_value));

    if (service_extract_seek_params(query_start, &seek_param_name,
                                    &seek_param_value,
                                    &seek_offset_seconds) < 0) {
      return NULL;
    }
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-05T09:47:27Z

src/http_proxy.c

+  /* Use per-service interface if specified, otherwise use global config */
+  if (service && service->ifname && service->ifname[0] != '\0') {
+    upstream_if = service->ifname;
+  } else {
+    upstream_if = get_upstream_interface_for_http();
+  }


http_proxy_connect() now dereferences service->ifname, but http_proxy.c only sees service_t as a forward declaration via http_proxy.h. This will not compile (incomplete type) unless you include service.h in http_proxy.c (or otherwise provide the full service_t definition) before accessing its fields.

Copilot · 2026-03-05T09:47:28Z

src/service.c

+    char ifname_value[IFNAMSIZ] = {0};
+    http_parse_query_param(query_start + 1, "r2h-ifname", ifname_value,
+                           sizeof(ifname_value));
+


service_create_from_http_url() extracts r2h-ifname but does not remove it from result->http_url. Since the HTTP proxy forwards target_path (including query string) upstream, this internal control parameter will be sent to the upstream server and may break requests. Consider stripping r2h-ifname from the stored URL similarly to how service_extract_seek_params() removes r2h-seek-* params.

Suggested change

/* Strip r2h-ifname from the stored HTTP URL so it is not forwarded upstream */

{

const char *orig_query = query_start + 1;

char new_query[HTTP_URL_BUFFER_SIZE] = {0};

size_t new_len = 0;

int first_param = 1;

const char *read = orig_query;

while (*read) {

const char *param_start = read;

const char *param_end = strchr(read, '&');

if (!param_end) {

param_end = read + strlen(read);

}

/* Determine parameter name and check if it is r2h-ifname */

const char *eq = memchr(param_start, '=', (size_t)(param_end - param_start));

int is_ifname_param = 0;

if (eq) {

size_t name_len = (size_t)(eq - param_start);

static const char ifname_key[] = "r2h-ifname";

if (name_len == (sizeof(ifname_key) - 1) &&

strncmp(param_start, ifname_key, name_len) == 0) {

is_ifname_param = 1;

}

}

if (!is_ifname_param) {

if (!first_param) {

if (new_len + 1 >= sizeof(new_query)) {

break;

}

new_query[new_len++] = '&';

}

size_t copy_len = (size_t)(param_end - param_start);

if (new_len + copy_len >= sizeof(new_query)) {

break;

}

memcpy(new_query + new_len, param_start, copy_len);

new_len += copy_len;

first_param = 0;

}

if (*param_end == '&') {

read = param_end + 1;

} else {

break;

}

}

new_query[new_len] = '\0';

/* Rebuild result->http_url without the r2h-ifname parameter */

{

size_t prefix_len = (size_t)(query_start - result->http_url);

if (new_len == 0) {

/* No query parameters remain; terminate the string at '?' */

result->http_url[prefix_len] = '\0';

} else {

result->http_url[prefix_len] = '?';

memcpy(result->http_url + prefix_len + 1, new_query, new_len + 1);

}

/* refresh query_start pointer in case the underlying buffer moved logically */

query_start = strchr(result->http_url, '?');

}

}

Copilot · 2026-03-05T09:47:28Z

src/service.c

+        free(result->url);
+        free(result->http_url);
+        free(result);


On strdup(ifname_value) failure, this function frees result, result->url, and result->http_url, but it does not free any seek-related allocations that may have been created by service_extract_seek_params() earlier in this block. Using service_free(result) (or explicitly freeing seek_param_name/seek_param_value) on this path will avoid leaking memory.

Suggested change

free(result->url);

free(result->http_url);

free(result);

service_free(result);

Initial plan

99f331d

Claude AI assigned Claude and stackia Mar 5, 2026

Claude started work on behalf of stackia March 5, 2026 09:04 View session

Claude AI and others added 2 commits March 5, 2026 09:09

Add ifname query parameter support for multicast interface selection

f2e9800

Co-authored-by: stackia <5107241+stackia@users.noreply.github.com>

Update documentation to include ifname parameter

6dcf8cf

Co-authored-by: stackia <5107241+stackia@users.noreply.github.com>

Claude AI changed the title ~~[WIP] Add http parameter for selecting multicast interface~~ Add ifname query parameter for per-URL multicast interface selection Mar 5, 2026

Claude finished work on behalf of stackia March 5, 2026 09:12

Claude started work on behalf of stackia March 5, 2026 09:14 View session

Copilot stopped work on behalf of stackia due to an error March 5, 2026 09:14
The session was cancelled by the user.

Claude started work on behalf of stackia March 5, 2026 09:17 View session

Claude AI and others added 2 commits March 5, 2026 09:28

Add r2h-ifname parameter support for RTSP, HTTP proxy, and multicast;…

d46b35a

… add r2h-ifname-fcc for FCC Co-authored-by: stackia <5107241+stackia@users.noreply.github.com>

Fix compilation errors: add service pointer to rtsp_session and forwa…

8d7ce35

…rd declaration Co-authored-by: stackia <5107241+stackia@users.noreply.github.com>

stackia marked this pull request as ready for review March 5, 2026 09:33

Copilot AI review requested due to automatic review settings March 5, 2026 09:33

Claude AI changed the title ~~Add ifname query parameter for per-URL multicast interface selection~~ Add r2h-ifname parameter support for RTSP, HTTP proxy, and multicast; rename ifname to r2h-ifname Mar 5, 2026

Claude finished work on behalf of stackia March 5, 2026 09:34

Copilot started reviewing on behalf of stackia March 5, 2026 09:34 View session

Claude started work on behalf of stackia March 5, 2026 09:37 View session

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

Copilot stopped work on behalf of stackia due to an error March 5, 2026 09:42
The session was cancelled by the user.

stackia closed this Mar 5, 2026

Copilot AI reviewed Mar 5, 2026

View reviewed changes

stackia deleted the claude/add-http-parameter-for-multicast branch March 7, 2026 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add r2h-ifname parameter support for RTSP, HTTP proxy, and multicast; rename ifname to r2h-ifname#378

Add r2h-ifname parameter support for RTSP, HTTP proxy, and multicast; rename ifname to r2h-ifname#378
Claude wants to merge 5 commits intomainfrom
claude/add-http-parameter-for-multicast

Claude AI commented Mar 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 5, 2026

Uh oh!

chatgpt-codex-connector bot Mar 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		http_parse_query_param(query_start + 1, "r2h-ifname", ifname_value,
		sizeof(ifname_value));

+    /* Strip r2h-ifname from the stored HTTP URL so it is not forwarded upstream */
+    {
+      const char *orig_query = query_start + 1;
+      char new_query[HTTP_URL_BUFFER_SIZE] = {0};
+      size_t new_len = 0;
+      int first_param = 1;
+      const char *read = orig_query;
+      while (*read) {
+        const char *param_start = read;
+        const char *param_end = strchr(read, '&');
+        if (!param_end) {
+          param_end = read + strlen(read);
+        }
+        /* Determine parameter name and check if it is r2h-ifname */
+        const char *eq = memchr(param_start, '=', (size_t)(param_end - param_start));
+        int is_ifname_param = 0;
+        if (eq) {
+          size_t name_len = (size_t)(eq - param_start);
+          static const char ifname_key[] = "r2h-ifname";
+          if (name_len == (sizeof(ifname_key) - 1) &&
+              strncmp(param_start, ifname_key, name_len) == 0) {
+            is_ifname_param = 1;
+          }
+        }
+        if (!is_ifname_param) {
+          if (!first_param) {
+            if (new_len + 1 >= sizeof(new_query)) {
+              break;
+            }
+            new_query[new_len++] = '&';
+          }
+          size_t copy_len = (size_t)(param_end - param_start);
+          if (new_len + copy_len >= sizeof(new_query)) {
+            break;
+          }
+          memcpy(new_query + new_len, param_start, copy_len);
+          new_len += copy_len;
+          first_param = 0;
+        }
+        if (*param_end == '&') {
+          read = param_end + 1;
+        } else {
+          break;
+        }
+      }
+      new_query[new_len] = '\0';
+      /* Rebuild result->http_url without the r2h-ifname parameter */
+      {
+        size_t prefix_len = (size_t)(query_start - result->http_url);
+        if (new_len == 0) {
+          /* No query parameters remain; terminate the string at '?' */
+          result->http_url[prefix_len] = '\0';
+        } else {
+          result->http_url[prefix_len] = '?';
+          memcpy(result->http_url + prefix_len + 1, new_query, new_len + 1);
+        }
+        /* refresh query_start pointer in case the underlying buffer moved logically */
+        query_start = strchr(result->http_url, '?');
+      }
+    }

Conversation

Claude AI commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @claude[agent] in this section)

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Claude AI commented Mar 5, 2026 •

edited

Loading