feat: Add generic database connection mechanism#754
Open
Conversation
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.tech>
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.tech>
19 tasks
sbernauer
commented
Mar 4, 2026
| /// The name of the Secret object containing the admin user credentials and database connection details. | ||
| /// Read the | ||
| /// TODO docs | ||
| pub metadata_database: MetadataDatabaseConnection, |
Member
Author
There was a problem hiding this comment.
BIG TODO: Currently this PR adds the field to v1alpha1 and v1alpha2. We need to discuss what our strategy with breaking changes and CRD versioning is.
Just to throw a random idea in: We might want to actually release this as v1alpha3 to not crash existing deployments (which kind of is the point of CRD versioning)
sbernauer
commented
Mar 4, 2026
| .await | ||
| .context(InvalidAuthorizationConfigSnafu)?; | ||
| // We don't have a config file, but do everything via env substitution | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#238
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker