Skip to content

feat: Add generic database connection mechanism#754

Open
sbernauer wants to merge 11 commits intomainfrom
feat/generic-database-connection
Open

feat: Add generic database connection mechanism#754
sbernauer wants to merge 11 commits intomainfrom
feat/generic-database-connection

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 4, 2026

Description

Part of stackabletech/issues#238

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

sbernauer and others added 7 commits March 3, 2026 10:51
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.tech>
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.tech>
/// The name of the Secret object containing the admin user credentials and database connection details.
/// Read the
/// TODO docs
pub metadata_database: MetadataDatabaseConnection,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIG TODO: Currently this PR adds the field to v1alpha1 and v1alpha2. We need to discuss what our strategy with breaking changes and CRD versioning is.
Just to throw a random idea in: We might want to actually release this as v1alpha3 to not crash existing deployments (which kind of is the point of CRD versioning)

@sbernauer sbernauer marked this pull request as ready for review March 4, 2026 14:29
.await
.context(InvalidAuthorizationConfigSnafu)?;
// We don't have a config file, but do everything via env substitution

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant