Skip to content

conditional support for solid v1 and v2#193

Open
birkskyum wants to merge 7 commits intosolidjs:masterfrom
birkskyum:solid-v1-v2-repl
Open

conditional support for solid v1 and v2#193
birkskyum wants to merge 7 commits intosolidjs:masterfrom
birkskyum:solid-v1-v2-repl

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 3, 2026

Features:

  • When you share it's saved if the repl is using solid v1/v2
  • Adjust default template ( @solidjs/web / solid-js/web )
  • vite-plugin-solid v2 for solid v1 and vite-plugin-solid v3 for solid v2
Screen.Recording.2026-03-04.at.00.04.39.mov

@milomg
Copy link
Member

milomg commented Mar 4, 2026

Hmm, I'm not sure I'm a fan of this more complicated build setup. I think we should probably use ESM imports like this old version of the playground used to milomg@0d8c858#diff-d89a6899cfba821b4b41912882cd05479ff1b6734710ed5ecc28ec2f04cfea61

I wonder if it also makes sense to build this on top of https://preview.playground.solidjs.com/scratchpad

@birkskyum
Copy link
Member Author

Sure, I'm good with anything - just wanted to get something going now that solid v2 is in beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants