Skip to content

[feat] msys2 support#574

Open
zdm wants to merge 9 commits intosindrets:mainfrom
softvisio:feat-msys2-support
Open

[feat] msys2 support#574
zdm wants to merge 9 commits intosindrets:mainfrom
softvisio:feat-msys2-support

Conversation

@zdm
Copy link

@zdm zdm commented May 1, 2025

Adds support for cygwin based git distributions.
Tested under MSYS2 git.

Copy link

@searleser97 searleser97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved

@zdm
Copy link
Author

zdm commented May 2, 2025

I am finished.

@zdm
Copy link
Author

zdm commented May 5, 2025

I see that this project is not under active development.
Does it has any sense to create PR at all?

@shmerl
Copy link

shmerl commented Jun 1, 2025

I see that this project is not under active development.

Is it? I just found it and it would be unfortunate if it's abandoned. Is anyone maintaining an active fork?

dlyongemallo pushed a commit to dlyongemallo/diffview.nvim that referenced this pull request Feb 26, 2026
When running native Windows Neovim with Cygwin-based git, commands
like `rev-parse --show-toplevel` return Unix-style paths (e.g.
`/c/Users/...`) that Neovim cannot use. Detect this case and convert
via `cygpath --absolute --windows`. Only fires when `has('win32')` is
true and the path starts with `/`, so Linux/macOS users are unaffected.

Based on softvisio/diffview.nvim (commits a67c42d, 06232a8) and
upstream PR sindrets#574, with modifications: use `vim.trim()` instead of
manual newline stripping, add type annotations, use double quotes.
dlyongemallo pushed a commit to dlyongemallo/diffview.nvim that referenced this pull request Feb 26, 2026
When running native Windows Neovim with Cygwin-based git, commands
like `rev-parse --show-toplevel` return Unix-style paths (e.g.
`/c/Users/...`) that Neovim cannot use. Detect this case and convert
via `cygpath --absolute --windows`. Only fires when `has('win32')` is
true and the path starts with `/`, so Linux/macOS users are unaffected.

Based on softvisio/diffview.nvim (commits a67c42d, 06232a8) and
upstream PR sindrets#574, with modifications: use `vim.trim()` instead of
manual newline stripping, add type annotations, use double quotes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants