Reduce dependency preflight noise and fix WiX v6 detection#742
Merged
jasonleenaylor merged 2 commits intomainfrom Mar 6, 2026
Merged
Reduce dependency preflight noise and fix WiX v6 detection#742jasonleenaylor merged 2 commits intomainfrom
jasonleenaylor merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Reduces default verbosity of dependency preflight output, removes the legacy NuGet CLI check, and improves WiX v6 detection for SDK-style installer projects.
Changes:
- Adds
-Detailedand-PassThruto control verbosity and scripted output. - Removes the legacy NuGet CLI dependency check from preflight.
- Updates WiX v6 detection to recognize
Project Sdk="WixToolset.Sdk/..."(and PackageReference) patterns.
|
|
||
| $wixProjText = Get-Content -LiteralPath $wixProj -Raw | ||
| if ($wixProjText -match "WixToolset\\.Sdk") { | ||
| [xml]$wixProjXml = Get-Content -LiteralPath $wixProj |
There was a problem hiding this comment.
When casting file content to [xml], using Get-Content without -Raw returns an array of lines, which can be implicitly re-joined and is more error-prone than reading the file as a single string. Prefer Get-Content -Raw -LiteralPath $wixProj before the [xml] cast to make XML parsing behavior deterministic.
Suggested change
| [xml]$wixProjXml = Get-Content -LiteralPath $wixProj | |
| [xml]$wixProjXml = Get-Content -Raw -LiteralPath $wixProj |
papeh
reviewed
Mar 5, 2026
Contributor
papeh
left a comment
There was a problem hiding this comment.
Documentation for the new params would be good; otherwise, looks good.
papeh
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-PassThrufor scripted callers)Validation
./Build/Agent/Verify-FwDependencies.ps1./Build/Agent/Verify-FwDependencies.ps1 -IncludeOptional./Build/Agent/Verify-FwDependencies.ps1 -IncludeOptional -DetailedNotes
-Detailed.This change is