Skip to content

Reduce dependency preflight noise and fix WiX v6 detection#742

Merged
jasonleenaylor merged 2 commits intomainfrom
quieter_tool_checking
Mar 6, 2026
Merged

Reduce dependency preflight noise and fix WiX v6 detection#742
jasonleenaylor merged 2 commits intomainfrom
quieter_tool_checking

Conversation

@johnml1135
Copy link
Contributor

@johnml1135 johnml1135 commented Mar 5, 2026

Summary

  • make dependency preflight output compact by default (max 3 lines when checks pass)
  • remove legacy NuGet CLI warning/check from dependency preflight
  • fix WiX v6 detection to recognize SDK-style Project Sdk="WixToolset.Sdk/..."
  • stop emitting result-object table by default (add -PassThru for scripted callers)

Validation

  • ./Build/Agent/Verify-FwDependencies.ps1
  • ./Build/Agent/Verify-FwDependencies.ps1 -IncludeOptional
  • ./Build/Agent/Verify-FwDependencies.ps1 -IncludeOptional -Detailed

Notes

  • Detailed output remains available via -Detailed.
  • Compact output now reports accurate required/optional counts.

This change is Reviewable

Copilot AI review requested due to automatic review settings March 5, 2026 20:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces default verbosity of dependency preflight output, removes the legacy NuGet CLI check, and improves WiX v6 detection for SDK-style installer projects.

Changes:

  • Adds -Detailed and -PassThru to control verbosity and scripted output.
  • Removes the legacy NuGet CLI dependency check from preflight.
  • Updates WiX v6 detection to recognize Project Sdk="WixToolset.Sdk/..." (and PackageReference) patterns.


$wixProjText = Get-Content -LiteralPath $wixProj -Raw
if ($wixProjText -match "WixToolset\\.Sdk") {
[xml]$wixProjXml = Get-Content -LiteralPath $wixProj
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When casting file content to [xml], using Get-Content without -Raw returns an array of lines, which can be implicitly re-joined and is more error-prone than reading the file as a single string. Prefer Get-Content -Raw -LiteralPath $wixProj before the [xml] cast to make XML parsing behavior deterministic.

Suggested change
[xml]$wixProjXml = Get-Content -LiteralPath $wixProj
[xml]$wixProjXml = Get-Content -Raw -LiteralPath $wixProj

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 14s ⏱️ +34s
4 407 tests ±0  4 320 ✅ ±0  87 💤 ±0  0 ❌ ±0 
4 416 runs  ±0  4 329 ✅ ±0  87 💤 ±0  0 ❌ ±0 

Results for commit 4d990e9. ± Comparison against base commit 0d6dace.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@papeh papeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation for the new params would be good; otherwise, looks good.

@jasonleenaylor jasonleenaylor merged commit 07ec52e into main Mar 6, 2026
6 of 7 checks passed
@jasonleenaylor jasonleenaylor deleted the quieter_tool_checking branch March 6, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants