Skip to content

Reusable ci workflow#24

Open
nicosuave wants to merge 2 commits intomainfrom
reusable-ci-workflow
Open

Reusable ci workflow#24
nicosuave wants to merge 2 commits intomainfrom
reusable-ci-workflow

Conversation

@nicosuave
Copy link
Member

No description provided.

Track v1.4-andium branch instead of pinning to exact v1.4.4 tag so
point releases (v1.4.5, v1.4.6, ...) automatically rebuild the
extension with matching platform strings. Add weekday scheduled builds.

- Use duckdb/extension-ci-tools reusable _extension_distribution.yml
- Add branch = main to .gitmodules for submodule tracking
- Exclude wasm and untested platforms (gcc4, rtools, mingw) for now
- Enable rust_logs for debugging initial runs
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52e2695dde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}-${{ github.ref != 'refs/heads/main' && github.sha || '' }}
cancel-in-progress: true
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}-${{ github.ref != 'refs/heads/main' || github.sha }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore SHA in non-main concurrency key

The concurrency suffix now uses github.ref != 'refs/heads/main' || github.sha, which evaluates to the boolean true for every non-main run instead of a per-commit SHA. That collapses all runs on the same PR/branch into one concurrency group, and with cancel-in-progress: false they queue behind older runs rather than executing with the commit they were triggered for, delaying CI feedback on active branches.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant