Feat: event api disable via event registry address#109
Open
blockchainluffy wants to merge 3 commits intomainfrom
Open
Feat: event api disable via event registry address#109blockchainluffy wants to merge 3 commits intomainfrom
blockchainluffy wants to merge 3 commits intomainfrom
Conversation
… and swagger docs update
ylembachar
reviewed
Mar 2, 2026
| return func(ctx *gin.Context) { | ||
| if config.DisableEventAPI { | ||
| err := sherror.NewHttpError( | ||
| "Service is unavailable.", |
Collaborator
There was a problem hiding this comment.
Maybe we should then align this error message with the 501 error, and have it as "Event API is disabled on this deployment" instead of "Service unavailable" which is usually with the 503 error code?
main.go
Outdated
| return | ||
| } | ||
| // Disable event API if event registry contract address is not configured | ||
| config.DisableEventAPI = shutterEventRegistryContractAddressStringified == "" |
Collaborator
There was a problem hiding this comment.
Perhaps a more robust check would be to verify that the event registry is a valid Ethereum address and enable the corresponding services then?
| err := sherror.NewHttpError( | ||
| "Service is unavailable.", | ||
| "Service is unavailable.", | ||
| http.StatusNotImplemented, |
Collaborator
There was a problem hiding this comment.
This new response is not reflected on the API docs, example here: https://github.com/shutter-network/shutter-api/blob/main/internal/service/crypto.go#L53 and in other endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #106