Conversation
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-5
branch
13 times, most recently
from
5305e7d to
670da80
Compare
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-7
branch
16 times, most recently
from
51e8e9c to
3d0f040
Compare
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-7
branch
from
3d0f040 to
e09c5a5
Compare
.github/docker-compose.yml
Outdated
| # =================== | ||
| # Cloudserver with MongoDB + Backbeat | ||
| # =================== | ||
| cloudserver-backbeat: |
There was a problem hiding this comment.
why not merge this with the cloudserver service?
(just need to drop the dependency on 'backbeat' if we want to be able to start it without all the backbeat/zookeeper/... stack)
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-5
branch
3 times, most recently
from
d7986fe to
5b20462
Compare
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-5
branch
5 times, most recently
from
04d210b to
b346637
Compare
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-5
branch
from
b346637 to
a3b3666
Compare
.github/workflows/test.yml
Outdated
| - name: Stop Cloudserver | ||
| if: always() | ||
| run: docker compose -f .github/docker-compose.cloudserver-mongo.yml down | ||
| run: docker compose -f .github/docker-compose.yml --env-file .github/docker.env --profile mongo down |
There was a problem hiding this comment.
is this needed? the runner will be destroyed anyway...
There was a problem hiding this comment.
this still applies @SylvainSenechal
| import { describeForBackbeatSetup } from './testHelpers'; | ||
| import assert from 'assert'; | ||
|
|
||
| // Note : these tests are relatively simple, as it's not straightforward to setup |
There was a problem hiding this comment.
note for thought (nothing to change now!) : instead of deploying "full" services (and thus having some sort of integration tests), we could have "mocked" the API in the tests (kind of more "unit test" approach, which avoids depending on the external packages & setting up all services)
SylvainSenechal
force-pushed
the
improvement/CLDSRVCLT-5
branch
2 times, most recently
from
00b92a5 to
18472a8
Compare
.github/docker-compose.backbeat.yml
Outdated
| start_period: 10s | ||
|
|
||
| mongodb-init: | ||
| image: mongo:4.4 |
There was a problem hiding this comment.
the higher ones aren't working on macs, I think its okish to keep it like this here
.github/workflows/test.yml
Outdated
| - name: Stop Cloudserver | ||
| if: always() | ||
| run: docker compose -f .github/docker-compose.cloudserver-metadata.yml down | ||
| run: docker compose -f .github/docker-compose.yml --env-file .github/docker.env --profile metadata down |
There was a problem hiding this comment.
.github/workflows/test.yml
Outdated
|
|
||
| - name: Stop Backbeat and Cloudserver | ||
| if: always() | ||
| run: docker compose -f .github/docker-compose.yml --env-file .github/docker.env --profile backbeat down No newline at end of file |
There was a problem hiding this comment.
| Size: Integer, | ||
|
|
||
| LastModified: Timestamp | ||
| } No newline at end of file |
| const input: GetLocationsIngestionStatusCommandInput = {}; | ||
| const cmd = new GetLocationsIngestionStatusCommand(input); | ||
| const result = await proxyBackbeatApisClient.send(cmd); | ||
| assert.strictEqual(result.$metadata.httpStatusCode, 200); |
There was a problem hiding this comment.
can't we add another assertion for this test and the others after ( not blocking but just to make sure we're receiving the intended infos )
There was a problem hiding this comment.
There isn't much data unfortunately for these as ingestion isn't setup, I will use this new client with the zenko tests to also test it
|
/approve |
|
I have successfully merged the changeset of this pull request
Please check the status of the associated issue CLDSRVCLT-5. Goodbye sylvainsenechal. The following options are set: approve |
4 participants
ISSUE: CLDSRVCLT-5