Open
Conversation
JonPurvis
suggested changes
Mar 2, 2026
JonPurvis
left a comment
JonPurvis
left a comment
There was a problem hiding this comment.
Great implementation!
I had one question regarding resolveCacheExpiry() which I've commented in the file.
Other than that, could you add some tests that:
- Cover
DateTimeImmutablebeing returned - Assert the cached entry is written with the correct expiry
- Any edge cases in
resolveCacheExpirysuch as 0, negative, date in the past
Thanks!
…-expiry # Conflicts: # src/Data/CachedResponse.php
|
Thanks for taking a look at my feedback, I'll get round to giving this a look over later this week / early next week. If it's all good, we can get it merged and get a new release out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.