Skip to content

chore(deps)!: upgrade serialize-javascript to v7 and node to v20#1968

Open
dargmuesli wants to merge 2 commits intorollup:masterfrom
dargmuesli:chore/deps/serializej-javascript
Open

chore(deps)!: upgrade serialize-javascript to v7 and node to v20#1968
dargmuesli wants to merge 2 commits intorollup:masterfrom
dargmuesli:chore/deps/serializej-javascript

Conversation

@dargmuesli
Copy link

Rollup Plugin Name: `terser

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Resolves #1959

Description

Upgrade serialize-javascript to v7 and node to v20 to resolve a security vulnerability notice.
BREAKING CHANGE: drop support for EOL node versions

BREAKING CHANGES: drop support for EOL node versions
@dargmuesli
Copy link
Author

@tada5hi I've pushed a change to let the ci pipelines match this PR's scope.

strategy:
matrix:
node: ['20', '18']
node: ['24', '20']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also include 22 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want an explicit for it, yes. If you just wanna check bounds, this could be sufficient. Comes down to being entirely sure or limiting resource usage and saving some of the planet as a trade off.

lemoustachiste added a commit to blockchain-certificates/ssi-sdk that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Bump terser dependencies

4 participants