[DO NOT MERGE] test jsc upgrade

[Kudo]

No description provided.

[Kudo]

Code review

Found 4 issues:

1. Smoke test reads Promise result before microtask queue drains -- runSmokeTest schedules a .then/.catch chain via Promise.resolve() in one JSEvaluateScript call and immediately reads __jscSmokeTestResult in a second call. The JSC C API does not automatically drain the microtask queue between JSEvaluateScript calls, so the result will be "pending" and the test will always throw. A call to drain microtasks (or a synchronous test) is needed between the two evaluations.

jsc-android-buildscripts/tools/android-js-runner/main.cpp

Lines 56 to 75 in 11ef4f9

	evaluateToString(
	ctx,
	"var __jscSmokeTestResult = undefined;\n"
	"Promise.resolve().then(function() {\n"
	" throw {value: JSON.stringify({foo: 1})};\n"
	"}).catch(function(error) {\n"
	" __jscSmokeTestResult = error.value;\n"
	"});\n"
	"__jscSmokeTestResult;");
	std::string capturedResult = evaluateToString(
	ctx,
	"typeof __jscSmokeTestResult === 'string'\n"
	" ? __jscSmokeTestResult\n"
	" : __jscSmokeTestResult === undefined ? 'pending' : String(__jscSmokeTestResult);");
	if (capturedResult != "{\"foo\":1}") {
	throw std::runtime_error("Unexpected result: " + capturedResult);
	}

2. Unstripped distribution directories are never archived -- The Archive step only copies dist-${{ matrix.variant }} but not dist-${{ matrix.variant }}.unstripped. The publish job's publish.js will silently skip the missing unstripped directories, so unstripped packages will never be published for any NDK variant.

jsc-android-buildscripts/.github/workflows/build_and_test.yml

Lines 158 to 166 in 11ef4f9

	run: |
	rm -rf archive
	mkdir -p archive
	if [[ -d "dist-${{ matrix.variant }}" ]]; then
	cp -R "dist-${{ matrix.variant }}" archive/
	else
	echo "Distribution directory dist-${{ matrix.variant }} was not produced." >&2
	exit 1
	fi

3. Publish job setup-node missing registry-url -- actions/setup-node only writes NODE_AUTH_TOKEN into .npmrc when registry-url is specified. Without it, npm publish will run unauthenticated and fail. Add registry-url: 'https://registry.npmjs.org' to the publish job's setup-node step.

jsc-android-buildscripts/.github/workflows/build_and_test.yml

Lines 280 to 283 in 11ef4f9

	- name: ⬢ Setup Node
	uses: actions/setup-node@v4
	with:
	node-version: 22

4. NDK variant ID mismatch breaks smoke tests -- package.json defines the NDK28 variant with "id": "ndk28c", but the CI matrix passes variant: ndk28. run-js-smoketest.sh does a strict ID lookup (entry.id === variantId) with no fallback, so it will exit with "Unknown NDK variant: ndk28" on every CI run.

jsc-android-buildscripts/package.json

Lines 44 to 46 in 11ef4f9

	{
	"id": "ndk28c",
	"label": "Android NDK r28c",

jsc-android-buildscripts/scripts/run-js-smoketest.sh

Lines 38 to 43 in 11ef4f9

	const variants = Array.isArray(pkg.config?.ndkVariants) ? pkg.config.ndkVariants : [];
	const variant = variants.find((entry) => entry && entry.id === variantId);
	if (!variant) {
	console.error(`Unknown NDK variant: ${variantId}`);
	process.exit(1);
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}