Skip to content

Arm backend: Correct per channel axis for transpose conv#17842

Merged
mansnils merged 1 commit intopytorch:mainfrom
mansnils:arm_backend_ops
Mar 5, 2026
Merged

Arm backend: Correct per channel axis for transpose conv#17842
mansnils merged 1 commit intopytorch:mainfrom
mansnils:arm_backend_ops

Conversation

@mansnils
Copy link
Collaborator

@mansnils mansnils commented Mar 4, 2026

Adjust per-channel weight axis for conv_transpose2d based on group(s).

The corrected axis is propagated to:

  • QuantizationSpec
  • QAT fake-quant constructors wrapped in PartialWrapper
  • Non-QAT observer/fake-quant constructors (via with_args)

cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @Sebastian-Larsson @robell

Adjust per-channel weight axis for conv_transpose2d based on
group(s).

The corrected axis is propagated to:
- QuantizationSpec
- QAT fake-quant constructors wrapped in PartialWrapper
- Non-QAT observer/fake-quant constructors (via with_args)

Signed-off-by: Måns Nilsson <mans.nilsson@arm.com>
Change-Id: I7bbe982a67b317253467ae7224307af8e6b34e78
@mansnils mansnils requested a review from digantdesai as a code owner March 4, 2026 12:49
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17842

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 3 New Failures, 3 Unrelated Failures

As of commit ba71305 with merge base 389ea94 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Mar 4, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 4, 2026

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Mar 4, 2026
@mansnils mansnils merged commit 17cb87c into pytorch:main Mar 5, 2026
153 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants