Skip to content

Arm backend: Increase qtol in Llama partial quant tests#17816

Merged
mansnils merged 1 commit intopytorch:mainfrom
mansnils:misc
Mar 5, 2026
Merged

Arm backend: Increase qtol in Llama partial quant tests#17816
mansnils merged 1 commit intopytorch:mainfrom
mansnils:misc

Conversation

@mansnils
Copy link
Collaborator

@mansnils mansnils commented Mar 3, 2026

Additionally,

  • Adds new scale error log.
  • Fix error log by printing actual tolerance instead of hard coded values.

cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @Sebastian-Larsson @robell

Additionally,
* Adds new scale error log.
* Fix error log by printing actual tolerance instead of hard coded
  values.

Change-Id: Ia36723e41e0bde4b3e3c42fac27e05eb7822dad3

Signed-off-by: Måns Nilsson <mans.nilsson@arm.com>
Change-Id: I17619d716d1235e6f5a515fc2a232adb6356aead
@mansnils mansnils requested a review from digantdesai as a code owner March 3, 2026 10:38
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17816

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending, 3 Unrelated Failures

As of commit 8d88fe1 with merge base 389ea94 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2026
@mansnils
Copy link
Collaborator Author

mansnils commented Mar 3, 2026

@pytorchbot label "partner:arm" , "release notes: none" , "ciflow/trunk"

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2026

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Mar 3, 2026
@mansnils mansnils merged commit e248a99 into pytorch:main Mar 5, 2026
315 of 325 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants