feat: show LRCLIB lyrics in Now Playing view with caching#25
Open
pythoninthegrass wants to merge 1 commit intomainfrom
Open
feat: show LRCLIB lyrics in Now Playing view with caching#25pythoninthegrass wants to merge 1 commit intomainfrom
pythoninthegrass wants to merge 1 commit intomainfrom
Conversation
Add lyrics fetching from lrclib.net with per-track SQLite caching. When lyrics are available, the Now Playing left panel switches to a compact album art header with a scrollable lyrics panel below. When no lyrics are found the view remains unchanged. Backend: db/lyrics.rs (cache CRUD), lyrics.rs (LRCLIB HTTP client with 10s timeout, mt-desktop User-Agent), commands/lyrics.rs (lyrics_get cache-first async command, lyrics_clear_cache). Negative results are cached to avoid repeated failed lookups. Frontend: api/lyrics.js (Tauri command wrapper), now-playing-view.js (lyrics state with visibility-gated fetching, superseded-fetch guard), now-playing.html (conditional two-layout rendering). Tests: 11 Rust tests (DB round-trip, LRCLIB response parsing), 12 Vitest tests (API invocation, visibility gating, track change, error handling). All 622 existing Rust + 331 Vitest tests pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lyrics fetching from lrclib.net with per-track SQLite caching. When lyrics are available, the Now Playing left panel switches to a compact album art header with a scrollable lyrics panel below. When no lyrics are found the view remains unchanged.
Backend: db/lyrics.rs (cache CRUD), lyrics.rs (LRCLIB HTTP client with 10s timeout, mt-desktop User-Agent), commands/lyrics.rs (lyrics_get cache-first async command, lyrics_clear_cache). Negative results are cached to avoid repeated failed lookups.
Frontend: api/lyrics.js (Tauri command wrapper), now-playing-view.js (lyrics state with visibility-gated fetching, superseded-fetch guard), now-playing.html (conditional two-layout rendering).
Tests: 11 Rust tests (DB round-trip, LRCLIB response parsing), 12 Vitest tests (API invocation, visibility gating, track change, error handling). All 622 existing Rust + 331 Vitest tests pass.