Conversation
The `lib` object in `src/stdlib/re.py` is created via `cffi.FFI().dlopen()`. Pyright, as a static analyzer, cannot detect the attributes (`free`, `free_matches`) that CFFI adds dynamically at runtime from the C library. This commit adds `# pyright: ignore [reportAttributeAccessIssue]` comments to the lines where these C functions are accessed through the `lib` object. This silences the false positive errors reported by pyright, acknowledging that these attributes are indeed available when the code executes.
Updates the pyright-specific ignore comments to the more generic `# type: ignore[attr-defined]` for broader compatibility with different type checkers. This addresses the false positive errors from static analyzers that cannot detect attributes dynamically added by CFFI at runtime. The `[attr-defined]` code is suitable for Mypy and also recognized by Pyright for this kind of attribute access issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.