Pin uvloop<0.22 and add sanity test for it#7432
Open
Conversation
0.22.1 is known to broke some existing behavior. Maybe there is a fix in our code, but we'll wait if they can revert it. See <MagicStack/uvloop#702>. Closes: pulp#7213
pedro-psb
force-pushed
the
pin-uvloop-and-add-test
branch
from
7934d3b to
b7b015f
Compare
Member
Author
|
Maybe the I've tested that it correctly fails without the bump, and that other errors (like missing setuptools) causes the script to fail too. https://github.com/pulp/pulpcore/actions/runs/22871481521/job/66352488860?pr=7432#step:13:752 |
Member
|
How about using a test scenario to run with uv? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.22.1is known to broke some existing behavior. Maybe there is a fix in our code, but we'll wait if they can revert/fix it on their side.See MagicStack/uvloop#702.
Closes: #7213
📜 Checklist
See: Pull Request Walkthrough