Add ShapeTests for Processing4 core module#1462
Open
aakritithecoder wants to merge 1 commit intoprocessing:mainfrom
Open
Add ShapeTests for Processing4 core module#1462aakritithecoder wants to merge 1 commit intoprocessing:mainfrom
aakritithecoder wants to merge 1 commit intoprocessing:mainfrom
Conversation
Author
|
This test ensures that PGraphics initializes width and height correctly when setSize() is called. |
catilac
requested changes
Mar 4, 2026
Collaborator
catilac
left a comment
catilac
left a comment
There was a problem hiding this comment.
Moving forward please create an issue first as per our guidelines.
This code is a good start for creating a test suite for PGraphics thank you!
Comment on lines
+6
to
+11
| public class ShapeTests { | ||
|
|
||
| @Test | ||
| public void testCanvasWidthAfterSetSize() { | ||
| // Create a PGraphics object and set its size | ||
| PGraphics pg = new PGraphics(); |
Collaborator
There was a problem hiding this comment.
This is testing PGraphics please update the class name, and place this in the core/test/processing/core folder
| // Assert that the canvas height is 150 | ||
| assertEquals(150, pg.height); | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
this test of the pg height can be done in the other test function that tests width.
Comment on lines
+14
to
+17
| pg.beginDraw(); | ||
| pg.rect(10, 10, 100, 50); // draw a rectangle | ||
| pg.endDraw(); | ||
|
|
Collaborator
There was a problem hiding this comment.
this is not necessary since you are testing setSize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ShapeTests.java under core/test/processing to verify canvas width and height initialization.
This ensures Processing’s PGraphics behaves as expected when setSize() is called.