feat(python): typed exceptions, Reader protocol, and bridge fix#178
Draft
cpsievert wants to merge 4 commits intofeat/vegalite-render-chartfrom
Draft
feat(python): typed exceptions, Reader protocol, and bridge fix#178cpsievert wants to merge 4 commits intofeat/vegalite-render-chartfrom
cpsievert wants to merge 4 commits intofeat/vegalite-render-chartfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…r, ReaderError, WriterError) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…onsistency The Reader protocol defines replace as a keyword parameter. Make the bridge path match so custom readers aren't required to accept it positionally. Update test custom readers accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #177 (merge that first)
Summary
ParseError,ValidationError,ReaderError,WriterError) subclassingValueErrorfor backwards compatibilityReaderprotocol class defining the contract for custom readers (execute_sql,register)PyReaderBridgeto passreplaceas a keyword argument, so custom readers withregister(name, df, *, replace=False)signatures work correctlyRust changes
create_exception!macros for 4 exception types +ggsql_err_to_py()mapper.map_err(...)sites updated from genericPyValueErrorto typed exceptionsPyReaderBridge.register()usescall_methodwith kwargs instead ofcall_method1