Merged
Conversation
teunbrand
reviewed
Mar 9, 2026
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
There is some great stuff in this PR.
Most of the comments below are very minor, but the less minor of these are the following:
- The error that shows up on the CI should be fixed.
- I think the page about the draw clause should include a short paragraph on position adjustments and link out to the specific pages.
- I'd like to suggest that duplicated logic be distilled in various places.
- I don't really understand why position parameters should get special treatment in some cases. Especially in the builder if we just purely use that to represent direct user input without doing validation yet. Maybe we should introduce the equivalent of
setup_params()or something for layers.
teunbrand
approved these changes
Mar 10, 2026
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
Once tests pass this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #100
This PR provides position adjustment functionality to ggsql, taking full responsibility for it and turns off any stacking and dodging done be vegalite.
It provides 3 position algorithms: stack, dodge, and jitter, all of which can be tailored in different ways (fill is a special case of stack, jitter dodge is part of jitter, Sina plot are also a jitter special case)