Open
Conversation
drealecs
requested review from
SakiTakamachi,
arnaud-lb,
bukka,
dstogov and
ndossche
as code owners
drealecs
force-pushed
the
improve-array-reduce-consume-carry
branch
2 times, most recently
from
86f212d to
2f9aa58
Compare
drealecs
changed the title
drealecs
force-pushed
the
improve-array-reduce-consume-carry
branch
from
2f9aa58 to
3299db5
Compare
Member
|
Can you provide the benchmark you used to verify this improves the situation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8283
For some callback operations, it is safe to consume/reuse a value passed as a parameter instead of copying it first.
This PR adds a generic internal mechanism for that (zend_fcall_info.consume_params) and applies it to array_reduce() carry handling.
This reduces copy-on-write churn and significantly improves array_reduce() performance for mutable accumulator patterns, while keeping userland semantics unchanged.
The same mechanism can be used in other callback-heavy paths in follow-up changes.