Skip to content

Propagate bind error for stream_socket_server() #21328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iluuu1994 wants to merge 2 commits into
base: master
Choose a base branch
from
+25 −1
Open

Propagate bind error for stream_socket_server() #21328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a49ced0
Propagate bind error stream_socket_server()
iluuu1994 Mar 3, 2026
0647712
Fix test for alpine, and skip for windows
iluuu1994 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ext/standard/tests/network/stream_socket_server_bind_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
stream_socket_server() bind error
--SKIPIF--
<?php
if (substr(PHP_OS, 0, 3) == 'WIN' ) {
die('skip not for Windows');
}
?>
--FILE--
<?php

$server1 = stream_socket_server("tcp://0.0.0.0:0");
$name = stream_socket_get_name($server1, false);
$server2 = stream_socket_server("tcp://$name");
fclose($server1);

?>
--EXPECTF--
Warning: stream_socket_server(): Unable to connect to tcp://0.0.0.0:%d (Address %r(already )?%rin use) in %s on line %d
7 changes: 6 additions & 1 deletion main/streams/xp_socket.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,8 +699,13 @@ static inline int php_tcp_sockop_bind(php_stream *stream, php_netstream_data_t *

parse_unix_address(xparam, &unix_addr);

return bind(sock->socket, (const struct sockaddr *)&unix_addr,
int result = bind(sock->socket, (const struct sockaddr *)&unix_addr,
(socklen_t) XtOffsetOf(struct sockaddr_un, sun_path) + xparam->inputs.namelen);
if (result == -1 && xparam->want_errortext) {
char errstr[256];
xparam->outputs.error_text = strpprintf(0, "%s", php_socket_strerror_s(errno, errstr, sizeof(errstr)));
}
return result;
}
#endif

Expand Down
Loading