fix allOf of oneOfs by introducing cartesian product#982
Open
PolyProgrammist wants to merge 3 commits intooxidecomputer:mainfrom
Open
fix allOf of oneOfs by introducing cartesian product#982PolyProgrammist wants to merge 3 commits intooxidecomputer:mainfrom
PolyProgrammist wants to merge 3 commits intooxidecomputer:mainfrom
Conversation
Author
|
@ahl could you please review? |
Author
ahl
reviewed
Mar 3, 2026
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
this seems reasonable, and the improvement to the github output is encouraging.
| new_variants: &[Schema], | ||
| defs: &BTreeMap<RefKey, Schema>, | ||
| ) -> Vec<Schema> { | ||
| let mut result = Vec::new(); |
Collaborator
There was a problem hiding this comment.
it seems possible for there to be literal or effective duplicates in this list.
Author
There was a problem hiding this comment.
I see there may be oneOf: [A, B] and oneOf: [C, D]
And maybe something like oneOf[{}, {type: string}] and oneOf[{type:string}, {type:string}] where for all of them the result would be {type:string}.
Do you think comparing like that is enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #897