[FSSDK-10777] SSR improvements + RSC support addition#318
Open
junaed-optimizely wants to merge 13 commits into3.x.xfrom
Open
[FSSDK-10777] SSR improvements + RSC support addition#318junaed-optimizely wants to merge 13 commits into3.x.xfrom
junaed-optimizely wants to merge 13 commits into3.x.xfrom
Conversation
junaed-optimizely
changed the title
junaed-optimizely
changed the title
raju-opti
requested changes
Mar 5, 2026
Contributor
raju-opti
left a comment
raju-opti
left a comment
There was a problem hiding this comment.
looks good. Few comments
|
|
||
| ### ODP audience segments | ||
|
|
||
| ODP (Optimizely Data Platform) audience segments require fetching segment data via an async network call, which is not available during server rendering. To include segment data during SSR, pass pre-fetched segments via the `qualifiedSegments` prop on `OptimizelyProvider`: |
Contributor
There was a problem hiding this comment.
An example of how to pre-fetch the segments would be good.
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright 2019, Optimizely | |||
| * Copyright 2026 Optimizely | |||
Contributor
There was a problem hiding this comment.
did you mean to add the year instead of replacing it?
| * limitations under the License. | ||
| */ | ||
|
|
||
| import hoistNonReactStatics from 'hoist-non-react-statics'; |
Contributor
There was a problem hiding this comment.
any particular reason for splitting this from utils.ts?
| const isClientReady = isServerSide || !!optimizely?.isReady(); | ||
| const isReadyPromiseFulfilled = !!optimizely?.getIsReadyPromiseFulfilled(); | ||
|
|
||
| const canMakeDecision = !!(optimizely?.getOptimizelyConfig() && optimizely.getUserContext()); |
Contributor
There was a problem hiding this comment.
Should make sync only when qualified segements is provided. Otherwise should wait for segment fetch to keep backwards compatibility
| // synchronous user context setting is required including for server side rendering (SSR) | ||
| this.setCurrentUserContext(userInfo); | ||
|
|
||
| if (this.userContext && !this.odpExplicitlyOff && this._client?.isOdpIntegrated() && qualifiedSegments) { |
Contributor
There was a problem hiding this comment.
do we want do the same in the if block as well (after line 399)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the documentation and implementation of server-side rendering (SSR) and ODP segment handling in the Optimizely React SDK V3.
It clarifies SSR usage in the README, adds a comprehensive Next.js integration guide, and updates the SDK's hooks to support more accurate decision-making during partial readiness states (such as when ODP segments are still being fetched). It also enhances test coverage for these scenarios.
Documentation improvements:
README.mdto explain the need for a pre-fetched datafile, updated setup instructions, and added a summary of SSR limitations. References to Next.js and React Server Components were added, and the SSR example was simplified.docs/nextjs-ssr.mdguide detailing integration patterns for both Next.js App Router and Pages Router, including code examples, feature flag usage, server component usage, and SSR limitations.SDK logic and behavior changes:
useExperiment,useFeature, anduseDecisionhooks to support synchronous decisions whengetOptimizelyConfigandgetUserContextare available, even if the client is not fully ready (e.g., ODP segments are still loading). This enables partial decisions during SSR or while waiting for async user/segment data. [1] [2] [3]Testing improvements:
Experiment.spec.tsx,Feature.spec.tsx, andhooks.spec.tsxto includegetOptimizelyConfigandgetUserContextmethods, simulating partial readiness and ODP scenarios. [1] [2] [3]Minor documentation and formatting fixes:
README.mdfor clarity and consistency. [1] [2] [3] [4] [5]These changes make SSR and ODP segment handling more robust and developer-friendly, especially for teams using Next.js or requiring partial readiness support.
Test plan
Issues