-
Notifications
You must be signed in to change notification settings - Fork 1
perf: compute dataflow analysis in Rust native engine #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,662
−39
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6184ac7
perf: compute dataflow analysis in Rust native engine
carlos-alm 0b64e25
fix: address PR review feedback for dataflow-in-rust
carlos-alm 46eaa11
fix(native): address dataflow review comments — conditional extractio…
carlos-alm 6b0a9e7
fix(native): use correct receiver field for Rust method call mutations
carlos-alm 5c67b54
fix(native): add depth guard to collect_identifiers in dataflow
carlos-alm 01d4b5f
perf: skip dataflow computation in incremental CFG-only rebuilds
carlos-alm 654a60b
fix: use >= for depth guard in collect_identifiers to match visit()
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dataflow computed unconditionally in CFG-only pending analysis pass
engineOpts.dataflowis set toopts.dataflow !== false(defaults totrue) for allparseFilesAutocalls. In the incremental "pending analysis" path at line 551,parseFilesAutois called insideif (needsCfg || needsDataflow). When onlyneedsCfgis true (e.g. a build that only needs to refresh CFG data), the native engine will traverse every file's full AST and populatesymbols.dataflow— work that is immediately discarded becauseif (needsDataflow)at line 556 isfalse.Before this PR,
engineOptshad nodataflowkey, so!!opts.dataflowresolved tofalseand the native engine skipped dataflow extraction entirely on this path. Now it is always computed by default, adding non-trivial overhead to incremental CFG-only rebuilds on large codebases.A targeted fix for the pending-analysis call site:
The main build path (line 711 →
allSymbols) is fine as-is becausebuildDataflowEdgesis guarded byif (opts.dataflow !== false)and uses the same symbol map.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e52c533 — the pending-analysis call site now overrides engineOpts.dataflow to only compute dataflow when needsDataflow is true. CFG-only incremental rebuilds no longer pay the dataflow extraction cost.