Let perftools to also bench OpenSSL forks.#79
Conversation
817f657 to
d02b44e
Compare
d09e327 to
b47c395
Compare
|
If you want to test thsoe changes to play around with them you need to apply diff below to cloned P$: |
| @@ -0,0 +1,88 @@ | |||
| #!/usr/bin/env ksh | |||
There was a problem hiding this comment.
is there a reason we're using ksh here as opposed to just sh?
There was a problem hiding this comment.
I got used to typeset to limit the scope of variables in shell. and I think typeset is ksh specific. I don't know if there is portable equivalent of typeset.
bench-scripts/common_util.sh
Outdated
| cd "${BORING_NAME}" | ||
| git clone "${BORING_REPO}" --depth 1 . || exit 1 | ||
| git clone "${BORING_REPO}" . || exit 1 | ||
| git checkout 0.20251124.0 || exit 1 |
There was a problem hiding this comment.
Do we want to run with a pinned version of boring here? Or should be be using the latest on master, since we're (I think) trying to get regular performance numbers updated over time?
There was a problem hiding this comment.
the master branch may not build. it happened to me once or twice. hence I opted for a tag.
There was a problem hiding this comment.
I've changed the code to use master branch and added comment how to work around in case of breakgae.
|
The code currently depends on .ksh script which does not fit well with ansible target after poking to cmake documentation I think it's worth to try bit harder and use cmake to fetch and build 3rd-party openssl libraries. the PR is going to land after #86 anyway. and #86 creates enough conflicts to resolve. |
bd4845a to
38f27a9
Compare
|
needs review the CMakeLists.txt after rebase. |
|
close + re-open to re-run CI. the failing tests correctly find openssl-4.0 but they fail to find |
056d574 to
2404277
Compare
|
just for the record, this is the change which makes CI happy the offending line got introduced during conflict resolution when rebasing to main branch my local test systems use cmake version 3.31, the github instance seems to be using 3.16. it's interesting the local systems with cmake3.31 don't notice the issue everything works there. I was lucky to meet my line 3 shows the linker command to build a binary. note the linker uses |
This change adjusts existing perftools so they cne be built by 3rd party SSL libraries (a.k.a. OpenSSL forks). Currently those tools can be used to bench OpenSSL forks: randbytes, rsasign, handshake, sslnew, x509storeissuer. evp_setpeer, writeread The change also adds bench_config_forks.sh which installs forks and builds perftools. And bench_run_forks.sh which runs tests and plots results. Fixes openssl/project#1845
This change adjusts existing perftools so they cne be built by 3rd party SSL libraries (a.k.a. OpenSSL forks). Currently those tools can be used to bench OpenSSL forks:
randbytes, rsasign, handshake, sslnew, x509storeissuer.
evp_setpeer, writeread
The change also adds bench_config_forks.sh which installs forks and builds perftools. And bench_run_forks.sh which runs tests and plots results.
Fixes openssl/project#1845