Refactor OpenMLEvaluation to use dataclass (Fixes #1540)#1701
Open
Sumitb09 wants to merge 3 commits intoopenml:mainfrom
Open
Refactor OpenMLEvaluation to use dataclass (Fixes #1540)#1701Sumitb09 wants to merge 3 commits intoopenml:mainfrom
Sumitb09 wants to merge 3 commits intoopenml:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1540
Summary
Refactored the
OpenMLEvaluationclass to use Python's@dataclassdecorator to simplify the class implementation and reduce boilerplate code.Changes
OpenMLEvaluationinto a@dataclass.asdict()for dictionary conversion in_to_dict.value,values, andarray_data) to maintain compatibility with existing usage.listinstead oftyping.List).Benefits
Testing
blackfor formatting.ruff check --fixfor linting.pytest.All tests pass successfully.
Before
The class relied on manual initialization and attribute assignments.
After
The class now uses Python's dataclass functionality, automatically generating
__init__,__repr__, and other utility methods.