[MNT] Remove temporary dummy jobs from CI workflow#1688
[MNT] Remove temporary dummy jobs from CI workflow#1688moksha-hub wants to merge 2 commits intoopenml:mainfrom
Conversation
Remove the 3 dummy jobs that were added temporarily in PR openml#1572: - dummy_windows_py_sk024 - dummy_windows_py_sk023 - dummy_docker These were added as a workaround when branch protection rules required jobs that no longer existed. They are no longer needed. Fixes openml#1573
|
@geetu040 please have a look. |
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
I think this is fine. We should remove these jobs. But I will leave this for @fkiraly, since he created the dummy jobs and ask if the reason for creating these in the first place is not relevant anymore.
I am still seeing these jobs in the CI with the message "Expected — Waiting for status to be reported". I think these should be removed if approved to run.
@fkiraly please approve the workflows and merge if it looks fine given the above context.
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
The dummy jobs are still required, because the admin console still has them as required jobs.
@PGijsbers, could you remove these from the admin console first? Otherwise tests will not be able to pass (these are dependent on ancient versions).
|
Removed |
4 participants
.github/workflows/test.yml:dummy_windows_py_sk024dummy_windows_py_sk023dummy_dockerThese jobs were added in PR #1572 as a temporary workaround when branch protection rules required jobs that no longer existed. They are no longer needed and should be removed.
Fixes #1573