Skip to content

[MNT] Update setup list test assertion#1652

Merged
fkiraly merged 4 commits intoopenml:mainfrom
omkar-334:filterflow
Mar 6, 2026
Merged

[MNT] Update setup list test assertion#1652
fkiraly merged 4 commits intoopenml:mainfrom
omkar-334:filterflow

Conversation

@omkar-334
Copy link
Contributor

@omkar-334 omkar-334 commented Feb 18, 2026

Fixes #1645

import openml

openml.config.server = "https://www.openml.org/api/v1/xml"
setups = openml.setups.list_setups(flow=5873)
Screenshot 2026-02-18 at 7 12 32 PM

Current number of setups is 2.

  1. For now, please keep using the production server for this test as the test server is not guaranteed to have setups (yet)
  2. Make the assertion based on a minimum. It is possible that people upload more runs for the flow (and consequently, more setups). It is also possible they delete them, but not so likely. So I would check a lower bound that is lower than what is currently on the production server.

cc @geetu040 @PGijsbers so should we use the lower bound as 1?

assert len(setups) >= 1

Copilot AI review requested due to automatic review settings February 18, 2026 13:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the assertion in test_setup_list_filter_flow to replace a placeholder check (assert len(setups) > 0) with a specific count check (assert len(setups) == 2) based on current production server data.

Changes:

  • Changed the setup list assertion from > 0 to == 2 to reflect the actual number of setups for flow ID 5873 on the production server

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@omkar-334
Copy link
Contributor Author

Screenshot 2026-02-18 at 7 17 57 PM tests passing

Copy link
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fkiraly please approve the workflows and merge.

Copilot AI review requested due to automatic review settings March 6, 2026 11:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.72%. Comparing base (39daaef) to head (bc3e73d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
- Coverage   53.07%   52.72%   -0.35%     
==========================================
  Files          37       37              
  Lines        4381     4381              
==========================================
- Hits         2325     2310      -15     
- Misses       2056     2071      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly merged commit e95675a into openml:main Mar 6, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Update Setup List Test Assertion to Be More Specific

5 participants