fix(ui): Sidebar scroll not showing last element#8563
fix(ui): Sidebar scroll not showing last element#8563malav2110 wants to merge 70 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
Updates the article sidebar container styling to ensure the sidebar can scroll fully and the last navigation item remains visible within the viewport.
Changes:
- Adjusted the article sidebar container from a fixed
100vhheight to amax-heightthat subtracts the header height CSS variable. - Bumped
@node-core/ui-componentspackage version from1.5.7to1.5.8.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/src/Containers/Article/index.module.css | Constrains the sticky sidebar’s scrollable height to the visible viewport area (accounting for header height). |
| packages/ui-components/package.json | Patch version bump for the UI components package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@malav2110 there's an odd effect here:
Screencast_20260126_144928.webmThere's a weird effect where the sidebar is not full width. This is how's supposed to look:
This is how it looks now in certain scroll positions:
|
|
@ovflowd Thanks for the video. I want to make sure I’m looking at the right things.
|
Not really, what I'm referring is the Sidebar is not full width, the Sidebar should go all the way to the bottom bar (not the footer), but the bar that has the breadcrumbs. |
|
Ah, got it. I see the gap you’re referring to now. I’ll fix this. |
|
@malav2110 with the current code now the issue is at the beginning of the sidebar ;)
|
|
Sharp eyes :) . I’ll address the top offset issue and make sure all scroll states are covered before the next push. |
| py-6 | ||
| sm:overflow-auto | ||
| sm:border-r | ||
| sm:pb-16 |
There was a problem hiding this comment.
Padding could probably be a bit smaller.
There was a problem hiding this comment.
There was a problem hiding this comment.
(I would recommend to avoid making assumptions, if I tell you it is possible or something the contrary, then I'm pretty sure it is possible 😛)
There was a problem hiding this comment.
(I just want to avoid giving you a solution plated, so you can try it yourself 👀)
There was a problem hiding this comment.
Got it. Thanks for the examples and for calling that out. That helps reset my assumptions.
Appreciate you pushing me to think it through rather than handing me the solution 🙂
There was a problem hiding this comment.
Absolutely! Although, I know I used a bit of a strong tone, apologies for that. Let me know if you get stuck and need support tho 🙇
There was a problem hiding this comment.
Thanks, appreciate that 🙂
I pushed a fix with reduced padding to address the issue that started the thread, and also resolved the merge conflict. Curious to hear your thoughts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8563 +/- ##
==========================================
- Coverage 75.03% 74.95% -0.09%
==========================================
Files 103 103
Lines 9062 9063 +1
Branches 312 312
==========================================
- Hits 6800 6793 -7
- Misses 2260 2268 +8
Partials 2 2 ☔ View full report in Codecov by Sentry. |
* chore: synced translations from crowdin * chore: automated format of translated files Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
…odejs#8667) * feat(ui-components): add Signature and FunctionSignature components * fix: title overflow and mobile return icon alignment * chore: patch version * fix: static heading tag can cause semantic problems * chore: unnecessary fragment removed * fix: wrong naming on signature stories * chore: unused classnames removed * chore: try to make Vercel happy * Update index.stories.tsx
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@b7c566a...bbbca2d) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roup (nodejs#8683) meta: bump @tailwindcss/postcss in the styling group Bumps the styling group with 1 update: [@tailwindcss/postcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/@tailwindcss-postcss). Updates `@tailwindcss/postcss` from 4.1.18 to 4.2.1 - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.2.1/packages/@tailwindcss-postcss) --- updated-dependencies: - dependency-name: "@tailwindcss/postcss" dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: styling ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps the testing group with 1 update: [jsdom](https://github.com/jsdom/jsdom). Updates `jsdom` from 28.0.0 to 28.1.0 - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md) - [Commits](jsdom/jsdom@28.0.0...28.1.0) --- updated-dependencies: - dependency-name: jsdom dependency-version: 28.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: testing ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the vercel group with 6 updates: | Package | From | To | | --- | --- | --- | | [turbo](https://github.com/vercel/turborepo) | `2.8.3` | `2.8.11` | | [@opentelemetry/api-logs](https://github.com/open-telemetry/opentelemetry-js) | `0.211.0` | `0.212.0` | | [@opentelemetry/instrumentation](https://github.com/open-telemetry/opentelemetry-js) | `0.211.0` | `0.212.0` | | [@opentelemetry/sdk-logs](https://github.com/open-telemetry/opentelemetry-js) | `0.211.0` | `0.212.0` | | [@vercel/otel](https://github.com/vercel/otel) | `2.1.0` | `2.1.1` | | [next-intl](https://github.com/amannn/next-intl) | `4.8.2` | `4.8.3` | Updates `turbo` from 2.8.3 to 2.8.11 - [Release notes](https://github.com/vercel/turborepo/releases) - [Changelog](https://github.com/vercel/turborepo/blob/main/RELEASE.md) - [Commits](vercel/turborepo@v2.8.3...v2.8.11) Updates `@opentelemetry/api-logs` from 0.211.0 to 0.212.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.211.0...experimental/v0.212.0) Updates `@opentelemetry/instrumentation` from 0.211.0 to 0.212.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.211.0...experimental/v0.212.0) Updates `@opentelemetry/sdk-logs` from 0.211.0 to 0.212.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.211.0...experimental/v0.212.0) Updates `@vercel/otel` from 2.1.0 to 2.1.1 - [Release notes](https://github.com/vercel/otel/releases) - [Commits](https://github.com/vercel/otel/compare/@vercel/otel@2.1.0...@vercel/otel@2.1.1) Updates `next-intl` from 4.8.2 to 4.8.3 - [Release notes](https://github.com/amannn/next-intl/releases) - [Changelog](https://github.com/amannn/next-intl/blob/main/CHANGELOG.md) - [Commits](amannn/next-intl@v4.8.2...v4.8.3) --- updated-dependencies: - dependency-name: turbo dependency-version: 2.8.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: vercel - dependency-name: "@opentelemetry/api-logs" dependency-version: 0.212.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: vercel - dependency-name: "@opentelemetry/instrumentation" dependency-version: 0.212.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: vercel - dependency-name: "@opentelemetry/sdk-logs" dependency-version: 0.212.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: vercel - dependency-name: "@vercel/otel" dependency-version: 2.1.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: vercel - dependency-name: next-intl dependency-version: 4.8.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: vercel ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nock](https://github.com/nock/nock) from 14.0.10 to 14.0.11. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](nock/nock@v14.0.10...v14.0.11) --- updated-dependencies: - dependency-name: nock dependency-version: 14.0.11 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [globals](https://github.com/sindresorhus/globals) from 16.5.0 to 17.3.0. - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v16.5.0...v17.3.0) --- updated-dependencies: - dependency-name: globals dependency-version: 17.3.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the mdx group with 5 updates: | Package | From | To | | --- | --- | --- | | [@shikijs/core](https://github.com/shikijs/shiki/tree/HEAD/packages/core) | `3.22.0` | `3.23.0` | | [@shikijs/engine-javascript](https://github.com/shikijs/shiki/tree/HEAD/packages/engine-javascript) | `3.22.0` | `3.23.0` | | [@shikijs/engine-oniguruma](https://github.com/shikijs/shiki/tree/HEAD/packages/engine-oniguruma) | `3.22.0` | `3.23.0` | | [@shikijs/twoslash](https://github.com/shikijs/shiki/tree/HEAD/packages/twoslash) | `3.22.0` | `3.23.0` | | [shiki](https://github.com/shikijs/shiki/tree/HEAD/packages/shiki) | `3.22.0` | `3.23.0` | Updates `@shikijs/core` from 3.22.0 to 3.23.0 - [Release notes](https://github.com/shikijs/shiki/releases) - [Commits](https://github.com/shikijs/shiki/commits/v3.23.0/packages/core) Updates `@shikijs/engine-javascript` from 3.22.0 to 3.23.0 - [Release notes](https://github.com/shikijs/shiki/releases) - [Commits](https://github.com/shikijs/shiki/commits/v3.23.0/packages/engine-javascript) Updates `@shikijs/engine-oniguruma` from 3.22.0 to 3.23.0 - [Release notes](https://github.com/shikijs/shiki/releases) - [Commits](https://github.com/shikijs/shiki/commits/v3.23.0/packages/engine-oniguruma) Updates `@shikijs/twoslash` from 3.22.0 to 3.23.0 - [Release notes](https://github.com/shikijs/shiki/releases) - [Commits](https://github.com/shikijs/shiki/commits/v3.23.0/packages/twoslash) Updates `shiki` from 3.22.0 to 3.23.0 - [Release notes](https://github.com/shikijs/shiki/releases) - [Commits](https://github.com/shikijs/shiki/commits/v3.23.0/packages/shiki) --- updated-dependencies: - dependency-name: "@shikijs/core" dependency-version: 3.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mdx - dependency-name: "@shikijs/engine-javascript" dependency-version: 3.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mdx - dependency-name: "@shikijs/engine-oniguruma" dependency-version: 3.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mdx - dependency-name: "@shikijs/twoslash" dependency-version: 3.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mdx - dependency-name: shiki dependency-version: 3.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mdx ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [chromaui/action](https://github.com/chromaui/action) from 15.1.1 to 15.2.0. - [Release notes](https://github.com/chromaui/action/releases) - [Changelog](https://github.com/chromaui/action/blob/main/CHANGELOG.md) - [Commits](chromaui/action@93712e3...5ec258a) --- updated-dependencies: - dependency-name: chromaui/action dependency-version: 15.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7.0.0 to 8.0.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@37930b1...70fc10c) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 2.14.1 to 2.15.0. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@5587c43...8818ff6) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-version: 2.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…8675) Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.14.2 to 2.15.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@5ef0c07...a90bcbc) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Create or Update Pull Request Action <create-or-update-pull-request@users.noreply.github.com>
…js#8681) Bumps the orama group with 1 update: [@orama/core](https://github.com/oramasearch/oramacore). Updates `@orama/core` from 1.2.16 to 1.2.19 - [Release notes](https://github.com/oramasearch/oramacore/releases) - [Commits](oramasearch/oramacore@v1.2.16...v1.2.19) --- updated-dependencies: - dependency-name: "@orama/core" dependency-version: 1.2.19 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: orama ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the storybook group with 3 updates: [@storybook/addon-themes](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/themes), [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5) and [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core). Updates `@storybook/addon-themes` from 10.2.6 to 10.2.13 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.2.13/code/addons/themes) Updates `@storybook/react-webpack5` from 10.2.6 to 10.2.13 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.2.13/code/frameworks/react-webpack5) Updates `storybook` from 10.2.10 to 10.2.13 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.2.13/code/core) --- updated-dependencies: - dependency-name: "@storybook/addon-themes" dependency-version: 10.2.13 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook - dependency-name: "@storybook/react-webpack5" dependency-version: 10.2.13 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook - dependency-name: storybook dependency-version: 10.2.13 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
|
Seems like I have messed up with the rebase process. Closing this and starting fresh. |












Description
Fixed the Sidebar scrolling issue where last item was not visible
Validation
Before:
Before.mov
After:
After.mov
Related Issues
Fixes: #8521
Closes: #8522
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.