Skip to content

crypto: fix importKey argument count check and add missing AES dictionaries#62099

Open
panva wants to merge 2 commits intonodejs:mainfrom
panva:minor-fixes
Open

crypto: fix importKey argument count check and add missing AES dictionaries#62099
panva wants to merge 2 commits intonodejs:mainfrom
panva:minor-fixes

Conversation

@panva
Copy link
Member

@panva panva commented Mar 4, 2026

This PR:

  • fixes SubtleCrypto.importKey to check for 5 arguments instead of 4
  • adds AesCbcParams.iv and AesCtrParams.counter to simpleAlgorithmDictionaries so their BufferSource inputs are properly copied before use

@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Mar 4, 2026
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 4, 2026
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (4d0cb65) to head (9c5bf31).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62099      +/-   ##
==========================================
- Coverage   91.63%   89.64%   -1.99%     
==========================================
  Files         337      676     +339     
  Lines      140376   206328   +65952     
  Branches    21768    39523   +17755     
==========================================
+ Hits       128627   184963   +56336     
- Misses      11527    13476    +1949     
- Partials      222     7889    +7667     
Files with missing lines Coverage Δ
lib/internal/crypto/util.js 95.43% <100.00%> (+2.77%) ⬆️
lib/internal/crypto/webcrypto.js 96.37% <100.00%> (+0.05%) ⬆️

... and 459 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2026
@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants