crypto: fix importKey argument count check and add missing AES dictionaries#62099
Open
panva wants to merge 2 commits intonodejs:mainfrom
Open
crypto: fix importKey argument count check and add missing AES dictionaries#62099panva wants to merge 2 commits intonodejs:mainfrom
panva wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62099 +/- ##
==========================================
- Coverage 91.63% 89.64% -1.99%
==========================================
Files 337 676 +339
Lines 140376 206328 +65952
Branches 21768 39523 +17755
==========================================
+ Hits 128627 184963 +56336
- Misses 11527 13476 +1949
- Partials 222 7889 +7667
🚀 New features to boost your workflow:
|
tniessen
approved these changes
Mar 4, 2026
Collaborator
cjihrig
approved these changes
Mar 4, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: