Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR addresses dependency stability by moving off a Preact beta release (which doesn’t follow semver reliably) and standardizing dependency locking with package-lock.json.
Changes:
- Downgrade
preactfrom^11.0.0-beta.0to the latest stable^10.28.4. - Use/refresh
package-lock.jsonto lock the dependency graph under the stable Preact version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Switches preact dependency from v11 beta to stable v10.28.4. |
| package-lock.json | Locks resolved dependencies to match the updated stable Preact dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
=======================================
Coverage 73.87% 73.87%
=======================================
Files 145 145
Lines 12867 12867
Branches 923 923
=======================================
Hits 9505 9505
Misses 3357 3357
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| File | Base | Head | Diff |
|---|---|---|---|
orama-db.json |
8.04 MB | 8.04 MB | -2.00 B (-0.00%) |
web Generator
| File | Base | Head | Diff |
|---|---|---|---|
styles.css |
128.16 KB | 128.22 KB | +67.00 B (+0.05%) |
MattIPv4
left a comment
There was a problem hiding this comment.
There is a really significant diff on the lockfile, including what looks to be a very large number of transitive dependency bumps which don't seem related to downgrading preact?
What is the history of why this uses shrinkwrap instead of a lockfile, as I imagine that was a very intentional decision, and I'd like to understand that before we move forward with undoing that decision?
Correct. The shrinkwrap and lockfile are different in how they function, so I had to regenerate the lockfile. All dependency changes, while they look unrelated, stay in the constraints we defined in the
It was an intentional decisions, made at a time when |
I'm not sure I follow this? You can look at the diff and clearly see the files are the same structure, you've just regenerated it and thus bumped all the transitive dependencies in the process -- while I agree it technically falls within bounds of the |
|
Per https://docs.npmjs.com/cli/v11/configuring-npm/npm-shrinkwrap-json, shrinkwarp is exactly the same as lockfile other than that it gets published with the package, so I do not see why regeneration + bumping versions was needed, it should just be a case of renaming the file? |
|
I knew they were the same structure, however, I didn't realize they were interchangeable (i.e. Sorry. |
|
No worries :) |
There was a problem hiding this comment.
We should keep npm-shrinkwrap. We're not installing doc-kit via git. npm-shrinkwrao was a requirement done by @aduh95 -- I'd appreciate if we don't keep reverting previous decisions then doing fast-track on such quick decisions. Ask questions first, please (check git blame, for example, understand why certain decisions were made instead of quickly challenging them). Thanks!
That was exactly what was done...
Based on that information, I've approved it as it seems fine to switch over to a regular lock now. |
I'm unsure this is the reason behind, and I would please have @aduh95 to chime in here first before we merge this. |
I didn't read the comments, sorry, I just quickly saw this PR and added a block to prevent it getting merged due to concerns I have. If Antoine gives a 👍 go for it, if not, please reach consensus 🙇 |
|
Yes, of course, it's never a bad idea to get more approvals. Just to clarify on the fast track, the web generator will not run in node core without this PR, so I requested a fast track to unblock my testing (which is currently done by just using the commit on this PRs head) |
|
The requirement came from nodejs/node#57343 (comment), as the idea at the time was to use npx at the time. Is there any pressing reason to go back to package-lock? |
Yes, the npm shrinkwrap isn't being respected, thus it serves no purpose. |
Can you please provide proof it is not being respected? And wdym by that? |
|
Even if it is not, there is no reason to go to package-lock. Sorry, for me this is a no. Not going to withdraw my block till better info is provided here, sorry Aviv 😭😅 |
|
Okay, I'll break this into two PRs. The preact downgrade is a direct blocker for moving core to the web generator, and I'll open a separate PR with more evidence as to switching is to the normal lock file |
I think that would have been the ideal from the go, btw! |
|
Yup |
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGMT ! but for the fast-track wait Antoine to answer
I mean it serves the purpose of a lock file, switching to
I have no opinion on the Preact downgrade, if it's a blocker fast-tracking seems like the correct course of action. |
I've made two discoveries in the past few minutes:
Requesting fast-track