Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 72.14% 70.80% -1.35%
==========================================
Files 117 128 +11
Lines 9992 11621 +1629
Branches 597 694 +97
==========================================
+ Hits 7209 8228 +1019
- Misses 2780 3390 +610
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 The code now dehydrates to the client so it can render without JavaScript! |
Wow 😵💫 and what about codetab |
|
It rehydrates and runs with JS, but if you don't have JS, you can still view the docs. I used React's SSRing |
|
@AugustinMauroy and I got search to finally work 🎉 |
024bbea to
dbfe55d
Compare
|
@nodejs/nodejs-website @nodejs/web-infra |
|
Oh hi @TheAlexLichter just wanted to randomly say thank you for chiming in here 🫶 |
|
@ovflowd Sure thing! 🙌 Glad I could help |
|
@nodejs/web-infra Is there anything else I missed that I still need to implement. Just waiting on a CODEOWNER review from y'all. We are almost there 🚀! |
ovflowd
left a comment
There was a problem hiding this comment.
Feature-wise
🚀 -- code wise, 👎
We need to add much more jsdocs, inline comments, extract regexes and things into constants and better simplify/cleanup the code.
Otherwise we will have a hug knowledge gap day one of what each logic means what it does and etc. I also appreciate exmaples on jsdocs. You can use Copilot or some Agentic stuff to help on that if it is massive 😅
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
@ovflowd I've plastered comments all over the code, hopefully it's more intuitive for the future :-). Let me know what else needs to be improved. |
ovflowd
left a comment
There was a problem hiding this comment.
I'd like you to see if you could simplify or outsource some of the complex .filter/.map functions, so that JavaScript doesn't need to redeclare the function on every call.
There are some visual nitpicks of my liking that if you don't mind would be nice (for me) to be addressed just as it makes my brain go less brrrr.
Finally, just give a last self-review, go through the whole diff slowly and see if there's anything you want to improved.
I'm approving with the hpyothesis that you're going to do that... Or....
|
just 270ish comments on the PR, 🍰 |
Sure! Let me know what they are, I'll be happy to investigate (or perhaps you already mentioned them, and I never resolved it?) |
Pretty much any assignment followed by if statement 😂 |
|
ahh, I thought you meant the UI |
|
Okay, we are so close, everyone! @ovflowd The following reviews remain unresolved:
I think I've resolved any assignment + if issues. |
|
Once those last few reviews are resolved, I'll merge this 🚀 |
|
@avivkeller feel free to merge! |
|
@avivkeller before you merge, ping me on Slack so I can adjust the main branch on Vercel. |


Fixes #7.
This PR adds the web generator.
Tasks / Issues
P1 – Must Complete Before Merge
P2 – Must complete before migration
P3 – Can Be Done in a Follow-up
mustachedependencyDataTagFootnotes
Add things as they appear, or leave review comments. ↩ ↩2 ↩3