fix(accounts): default property scopes to local instead of federated#58759
Open
boris324 wants to merge 3 commits intonextcloud:masterfrom
Open
fix(accounts): default property scopes to local instead of federated#58759boris324 wants to merge 3 commits intonextcloud:masterfrom
boris324 wants to merge 3 commits intonextcloud:masterfrom
Conversation
Add name="default_view" to the NcRadioGroup component so the underlying radio buttons are properly grouped. This enables keyboard navigation between radio options using arrow keys, improving accessibility. Fixes nextcloud#58729 Signed-off-by: boris324 <boris324@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AWS allows bucket names up to 63 characters per their naming rules, but the bucket_name column in oc_preview_locations was varchar(40). This updates the initial migration to use length 63 for fresh installs and adds a new migration to alter the column for existing installs. Fixes: nextcloud#58755 Signed-off-by: boris324 <boris324@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…to local New users were created with displayname, email, avatar, and pronouns set to federated scope by default, exposing personal information to federated servers without explicit user consent. This changes all default property scopes to local, so user data stays private until the user explicitly opts into federation. Includes a repair step to migrate existing users who still have the old federated defaults on the affected properties. Fixes: nextcloud#58646 Signed-off-by: boris324 <boris324@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
boris324
requested review from
artonge,
icewind1991,
leftybournes,
salmart-dev and
szaimen
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCOPE_FEDERATEDtoSCOPE_LOCALfor all properties (displayname, email, avatar, pronouns were previously federated by default)FixDefaultAccountScopesToLocal) that migrates existing users who still have the old federated defaults on the affected properties back to local scopeBackground
New users were created with
displayname,email,avatar, andpronounsset tov2-federatedscope by default. This exposed personal information to federated servers without explicit user consent. The privacy-respecting default should bev2-local, keeping user data visible only to users on the same instance.Administrators who want to restore the old behavior can use the
account_manager.default_property_scopesystem config option to override individual property scopes.Fixes: #58646
Test plan
v2-localscope in theoc_accountstableocc maintenance:repairand verify the repair step updates existing accounts fromv2-federatedtov2-localfor the affected propertiesv2-publishedorv2-privatescopes are not modified by the repair stepaccount_manager.default_property_scopeconfig override still works to set federated scope if desired🤖 Generated with Claude Code